Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boost 1.7x build incompatibility due to invalid method signature #238

Closed
dmeehan1968 opened this issue Oct 27, 2020 · 2 comments
Closed

Comments

@dmeehan1968
Copy link

Failing Code:

Boost commit that breaks Cucumber-cpp:

Compiler Error:

.../cucumber-cpp/src/drivers/BoostDriver.cpp:53:10: error: 'cucumber::internal::CukeBoostLogInterceptor::log_build_info' hides overloaded virtual function [-Werror,-Woverloaded-virtual]
    void log_build_info( std::ostream&) {};
         ^
/usr/local/include/boost/test/unit_test_log_formatter.hpp:144:25: note: hidden overloaded virtual function 'boost::unit_test::unit_test_log_formatter::log_build_info' declared here: different number of parameters (2 vs 1)
    virtual void        log_build_info( std::ostream& os, bool log_build_info = true ) = 0;
                        ^
.../cucumber-cpp/src/drivers/BoostDriver.cpp:122:26: error: allocating an object of abstract class type 'cucumber::internal::CukeBoostLogInterceptor'
    logInterceptor = new CukeBoostLogInterceptor;
                         ^
/usr/local/include/boost/test/unit_test_log_formatter.hpp:144:25: note: unimplemented pure virtual method 'log_build_info' in 'CukeBoostLogInterceptor'
    virtual void        log_build_info( std::ostream& os, bool log_build_info = true ) = 0;
                        ^
2 errors generated.
@dmeehan1968
Copy link
Author

Pull Request: #239

@jermus67
Copy link
Contributor

jermus67 commented Jul 9, 2021

Pull Request: #239 was marked (by @dmeehan1968) as a duplicate of pull request #225 . Pull request #225 has been merged, and the main branch now compiles with boost 1.7x.

Based on the above described observation I think this issue can be closed.

Thanks for the energy you put in helping fix the issue.

@jermus67 jermus67 closed this as completed Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants