Replace strip-ansi with native Node API (#2436)

cucumber · Oct 5, 2024 · edaf1c0 · edaf1c0
1 parent d612cc5
commit edaf1c0
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 6 deletions.
diff --git a/features/support/world.ts b/features/support/world.ts
@@ -6,7 +6,6 @@ import util from 'node:util'
 import { Console } from 'node:console'
 import { expect } from 'chai'
 import toString from 'stream-to-string'
-import stripAnsi from 'strip-ansi'
 import * as messages from '@cucumber/messages'
 import * as messageStreams from '@cucumber/message-streams'
 import FakeReportServer from '../../test/fake_report_server'
@@ -139,7 +138,7 @@ export class World {
       error: result.error,
       errorOutput: result.stderr,
       envelopes,
-      output: stripAnsi(result.stdout),
+      output: util.stripVTControlCharacters(result.stdout),
     }
     this.verifiedLastRunError = false
     expect(this.lastRun.output).to.not.include('Unhandled rejection')

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -247,7 +247,6 @@
     "resolve-pkg": "^2.0.0",
     "semver": "7.5.3",
     "string-argv": "0.3.1",
-    "strip-ansi": "6.0.1",
     "supports-color": "^8.1.1",
     "tmp": "0.2.3",
     "type-fest": "^4.8.3",

diff --git a/src/publish/publish_plugin.ts b/src/publish/publish_plugin.ts
@@ -1,7 +1,7 @@
 import { Writable } from 'node:stream'
+import { stripVTControlCharacters } from 'node:util'
 import { supportsColor } from 'supports-color'
 import hasAnsi from 'has-ansi'
-import stripAnsi from 'strip-ansi'
 import { InternalPlugin } from '../plugin'
 import { IPublishConfig } from './types'
 import HttpStream from './http_stream'
@@ -48,7 +48,7 @@ compose the console message on this end.
  */
 function sanitisePublishOutput(raw: string, stderr: Writable) {
   if (!supportsColor(stderr) && hasAnsi(raw)) {
-    return stripAnsi(raw)
+    return stripVTControlCharacters(raw)
   }
   return raw
 }