Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit testCase messages before test run starts #1408

Closed
davidjgoss opened this issue Aug 19, 2020 · 2 comments · Fixed by #1669
Closed

Emit testCase messages before test run starts #1408

davidjgoss opened this issue Aug 19, 2020 · 2 comments · Fixed by #1669
Assignees
Labels
🏦 debt Tech debt

Comments

@davidjgoss
Copy link
Contributor

Currently cucumber-js emits testCase messages right before each test case will be run. The CCK defines that they should be emitted together at the start of the test run.

(We're temporarily reordering the envelopes in our CCK test instrumentation at the moment.)

@davidjgoss
Copy link
Contributor Author

Consensus from wider group on this was that the ordering around these messages is not important - other implementatons also reorder their messaged to match CCK

@davidjgoss
Copy link
Contributor Author

Formatters that want to understand the progress of the test run are best served by emitting testCase messages all upfront, and with pickleAccepted and pickleRejected gone we also need it to solve #1579 nicely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏦 debt Tech debt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant