Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perl: Acceptance tests do not include parse errors #31

Closed
Tracked by #2
mpkorstanje opened this issue Nov 8, 2022 · 3 comments · Fixed by #149
Closed
Tracked by #2

perl: Acceptance tests do not include parse errors #31

mpkorstanje opened this issue Nov 8, 2022 · 3 comments · Fixed by #149

Comments

@mpkorstanje
Copy link
Contributor

🤔 What's the problem you've observed?

Currently the error set of tokens is not included in the acceptance tests.

acceptance: .built $(TOKENS) $(ASTS) $(PICKLES) $(SOURCES) #$(ERRORS) ## Build acceptance test dir and compare results with reference

This is a problem because:

As of May 2016 Gherkin is implemented in 8 languages. This number is likely to increase to a dozen within a year or two. Very few programmers are intimate with all those languages. Therefore, in order to make it as easy as possible to refactor, fix bugs, add features and release packages it is essential that all implementations have a similar structure.

CONTRIBUTING.md - consistency between implementations

✨ Do you have a proposal for making it better?

Fix the acceptance tests to include the parse errors.

@mpkorstanje mpkorstanje changed the title perl: perl: Acceptance tests do not include parse errors Nov 8, 2022
@mpkorstanje
Copy link
Contributor Author

@ehuelsmann could you have a look at this?

@mpkorstanje mpkorstanje mentioned this issue Nov 8, 2022
71 tasks
@ehuelsmann
Copy link
Contributor

yep. I'll have a look in the morning.

@mpkorstanje
Copy link
Contributor Author

Cheers! No rush at all, it's been like this for a while.

@ehuelsmann ehuelsmann mentioned this issue Aug 15, 2023
7 tasks
@ehuelsmann ehuelsmann linked a pull request Aug 15, 2023 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants