Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go: use standard header in generated file #134

Merged
merged 1 commit into from
Jul 15, 2023

Conversation

dolmen
Copy link
Contributor

@dolmen dolmen commented Jul 13, 2023

Use the standard header for Go generated files, following the spec at https://golang.org/s/generatedcode.

🤔 What's changed?

The template go/dialects_builtin.go.jq is fixed and go/dialects_builtin.go is regenerated.

⚡️ What's your motivation?

The standard header allows automated tools or IDE to block editing directly generated files. That could help the renovatebot to stop doing invalid changes (see #120 (comment) and renovatebot/renovate#21010 (comment)).

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)

📋 Checklist:

Use the standard header for Go generated files, following the spec at
https://golang.org/s/generatedcode.

The template go/dialects_builtin.go.jq is fixed and
go/dialects_builtin.go is regenerated.
@dolmen dolmen force-pushed the go-fix-header-for-generated-code branch from 2760325 to 64dbed9 Compare July 13, 2023 15:35
@dolmen
Copy link
Contributor Author

dolmen commented Jul 14, 2023

Cc: @krichprollsch

Copy link
Contributor

@mpkorstanje mpkorstanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Though I don't immediately see how this will help with the other problems you mentioned this is a useful improvement indeed.

@mpkorstanje mpkorstanje merged commit 1b9d38c into cucumber:main Jul 15, 2023
26 of 27 checks passed
@aslakhellesoy
Copy link
Contributor

Hi @dolmen,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants