Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: Add Belarusian (be) localization #98

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

EDbarvinsky
Copy link
Contributor

@EDbarvinsky EDbarvinsky commented Mar 16, 2023

⚡️ What's your motivation?

To have ability to use Belarusian based gherkin steps on project

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@EDbarvinsky EDbarvinsky force-pushed the Add_Belarusian_localization branch from c0cdb1d to dadfbcb Compare March 16, 2023 22:41
@EDbarvinsky EDbarvinsky marked this pull request as ready for review March 16, 2023 22:42
@EDbarvinsky
Copy link
Contributor Author

Hello, @mpkorstanje! I do not see proper changes for java and objective-c is it expected?
Would appreciate your review :-)

@EDbarvinsky EDbarvinsky force-pushed the Add_Belarusian_localization branch from dadfbcb to cbce9ea Compare March 16, 2023 22:47
Copy link
Contributor

@mpkorstanje mpkorstanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see proper changes for java and objective-c is it expected?

Yup. That is expected. Java generates the code from the file in the root directory. Objective-c isn't really maintained. If you know how to make Objective-c work with the current process you'd be most welcome to suggest a fix.

CHANGELOG.md Show resolved Hide resolved
c/src/dialect.c Outdated Show resolved Hide resolved
dotnet/Gherkin/gherkin-languages.json Outdated Show resolved Hide resolved
ruby/lib/gherkin/gherkin-languages.json Outdated Show resolved Hide resolved
php/resources/gherkin-languages.json Outdated Show resolved Hide resolved
javascript/src/gherkin-languages.json Outdated Show resolved Hide resolved
go/dialects_builtin.go Outdated Show resolved Hide resolved
gherkin-languages.json Outdated Show resolved Hide resolved
elixir/priv/gherkin_languages.json Outdated Show resolved Hide resolved
@EDbarvinsky EDbarvinsky force-pushed the Add_Belarusian_localization branch 2 times, most recently from b001751 to 81ea655 Compare March 16, 2023 23:06
@EDbarvinsky
Copy link
Contributor Author

I do not see proper changes for java and objective-c is it expected?

Yup. That is expected. Java generates the code from the file in the root directory. Objective-c isn't really maintained. If you know how to make Objective-c work with the current process you'd be most welcome to suggest a fix.

sorry i have no clue in objective-c, but promise to take a look on opened issues and let u know in case if i will have ability\knowledge to fix smth

@EDbarvinsky EDbarvinsky requested a review from mpkorstanje March 16, 2023 23:09
@EDbarvinsky EDbarvinsky force-pushed the Add_Belarusian_localization branch 3 times, most recently from 960e5f8 to d2512a4 Compare March 17, 2023 09:31
@EDbarvinsky EDbarvinsky force-pushed the Add_Belarusian_localization branch from d2512a4 to eb2a677 Compare March 17, 2023 10:47
@EDbarvinsky EDbarvinsky changed the title i18n: Add Belarusian (by) localization i18n: Add Belarusian (be) localization Mar 17, 2023
@EDbarvinsky EDbarvinsky requested review from skarpesh and mpkorstanje and removed request for mpkorstanje and skarpesh March 17, 2023 12:34
c/src/dialect.c Outdated Show resolved Hide resolved
dart/assets/gherkin-languages.json Outdated Show resolved Hide resolved
go/dialects_builtin.go Outdated Show resolved Hide resolved
@EDbarvinsky EDbarvinsky force-pushed the Add_Belarusian_localization branch from eb2a677 to 8b0658f Compare March 20, 2023 08:32
@EDbarvinsky EDbarvinsky requested review from uladz-zubrycki and mpkorstanje and removed request for mpkorstanje and uladz-zubrycki March 20, 2023 08:33
@mpkorstanje mpkorstanje merged commit dd8fb1f into cucumber:main Mar 20, 2023
@aslakhellesoy
Copy link
Contributor

Hi @EDbarvinsky,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

@mpkorstanje
Copy link
Contributor

Probably released next week Thursday, depending on available time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants