-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement unambiguous keywords #509
Implement unambiguous keywords #509
Conversation
chore(*): update messages and gherkin, relocate Keyword chore(*): update messages and gherkin, relocate Keyword
…ng keyword functions
Linking cucumber/common#768 |
Codecov Report
@@ Coverage Diff @@
## main #509 +/- ##
==========================================
- Coverage 82.10% 81.66% -0.44%
==========================================
Files 27 27
Lines 3314 2302 -1012
==========================================
- Hits 2721 1880 -841
+ Misses 484 321 -163
+ Partials 109 101 -8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Updated tests, should increase diff coverage to 100% |
Looks good for the actual implementation, but for dependencies update it seems to be slightly misaligned with current strategy. We were thinking to migrate to use I suggest we migrate to those new modules in a separate pull request, and then rebase this one to only cover actual |
Thanks for the review! I did see that there was a change in strategy for dependencies, but I was having trouble importing those dependencies from those new repos. The primary reason why I switched to the common repo to begin with is that this PR needed those dependencies to be updated but I was facing the same issues importing cucumber/messages repo, due to the same issue,
It seems these modules still declare themselves as Either way I'm happy to open new PR's to fix this and then rebase. |
# Conflicts: # CHANGELOG.md # _examples/go.mod # _examples/go.sum # formatters/fmt.go # go.mod # go.sum # internal/formatters/fmt.go # internal/formatters/fmt_base.go # internal/formatters/fmt_cucumber.go # internal/formatters/fmt_events.go # internal/formatters/fmt_multi.go # internal/formatters/fmt_pretty.go # internal/formatters/fmt_progress.go # internal/formatters/undefined_snippets_gen.go # internal/models/feature.go # internal/models/stepdef.go # internal/models/stepdef_test.go # internal/parser/parser.go # internal/storage/storage.go # internal/storage/storage_test.go # internal/tags/tag_filter.go # internal/tags/tag_filter_test.go # internal/testutils/utils.go # run.go # run_progress_test.go # run_test.go # suite.go # suite_context_test.go # test_context.go
Rebased branch to cover keyword functions only |
🤔 What's changed?
Given()
,When()
, andThen()
totest_context.go
Step()
but only match a feature step when their specific keyword is used⚡️ What's your motivation?
Resolves #479
🏷️ What kind of change is this?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.