Before/After Feature Hook Types?

[clrudolphi]

🤔 What's the problem you're trying to solve?

I see in the recently merged and released #102 that an enumeration has been added that outlines the types of Hooks (Before/After TestRun, BeforeAfter TestCase, and Before/After TestStep).

The .NET implementations (Reqnroll and SpecFlow before it) also support hooks that surround Features.

✨ What's your proposed solution?

Would it be acceptable to add two additional HookType enumeration values to the list (BeforeFeature and AfterFeature)?

⛏ Have you considered any alternatives or workarounds?

No response

📚 Any additional context?

No response

[luke-hill]

I personally wouldn't support this, as a feature is just a set of test cases. You shouldn't ideally be doing something around a feature. Plus the concept of tagging is in place for this - should you want to run something before only some subset of your tests.

If something is unique to specflow/reqnroll for this. It probably should live as something custom for it

[mpkorstanje]

Would it be acceptable to add two additional HookType enumeration values to the list (BeforeFeature and AfterFeature)?

@clrudolphi would that not also require a message to indicate a feature started?

If something is unique to specflow/reqnroll for this. It probably should live as something custom for it

@luke-hill that's a tricky one.

I do think that feature hooks enable some really bad practices. But at the same time, for the ecosystem as a whole I'd rather see that we have a common messages format. The community would really benefit from the network effect it creates.

[clrudolphi]

would that not also require a message to indicate a feature started?

Very likely, yes. There would be the need to associate which Feature the hook is related to (in a stream with multiple features execution intermixed).