Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stray LICENSE installed into site-packages #320

Closed
mgorny opened this issue Aug 25, 2024 · 2 comments
Closed

Stray LICENSE installed into site-packages #320

mgorny opened this issue Aug 25, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@mgorny
Copy link
Contributor

mgorny commented Aug 25, 2024

Describe the bug
The package installs a stray LICENSE file to the top directory of site-packages.

To Reproduce

$ pip install fakeredis
Collecting fakeredis
  Downloading fakeredis-2.24.0-py3-none-any.whl.metadata (3.8 kB)
Collecting redis>=4 (from fakeredis)
  Using cached redis-5.0.8-py3-none-any.whl.metadata (9.2 kB)
Collecting sortedcontainers<3,>=2 (from fakeredis)
  Using cached sortedcontainers-2.4.0-py2.py3-none-any.whl.metadata (10 kB)
Downloading fakeredis-2.24.0-py3-none-any.whl (97 kB)
Using cached redis-5.0.8-py3-none-any.whl (255 kB)
Using cached sortedcontainers-2.4.0-py2.py3-none-any.whl (29 kB)
Installing collected packages: sortedcontainers, redis, fakeredis
Successfully installed fakeredis-2.24.0 redis-5.0.8 sortedcontainers-2.4.0
$ ls $VIRTUAL_ENV/lib/python*/site-packages
fakeredis                   LICENSE  pip-24.2.dist-info  redis-5.0.8.dist-info  sortedcontainers-2.4.0.dist-info
fakeredis-2.24.0.dist-info  pip      redis               sortedcontainers

Note the LICENSE file that shouldn't be there.

Expected behavior
All files installed into fakeredis directory.

Screenshots
n/a

Desktop (please complete the following information):

  • OS: Gentoo Linux amd64
  • python version: 3.12.5
  • redis-py version: 2.24.0
  • full requirements.txt? n/a

Additional context
Apparently this is because LICENSE is listed in tool.poetry.packages.

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue.
  • We receive the funding once the issue is completed & confirmed by you.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar
@mgorny mgorny added the bug Something isn't working label Aug 25, 2024
@cunla
Copy link
Owner

cunla commented Aug 26, 2024

thanks for reporting this. Fixed in 2.24.1

@cunla cunla closed this as completed Aug 26, 2024
@mgorny
Copy link
Contributor Author

mgorny commented Aug 26, 2024

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants