-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error in CI deployment of Storybook for components with hooks #114
Comments
There is some problem with versioning, because when I run
"@cura/hooks": "0.0.6",
"@cura/hooks": "^0.0.8", https://www.npmjs.com/package/@cura/hooks is |
I'm not sure that's the problem @achrafismyname. In #111 I tried all types of combinations. It seems to only happen with |
The problemThe problem here, is that And when we use Workarounds
I opened this PR below for now with a solution for CI. And added But I saw in #116 that @devey is working on upgrading yarn, so I think it's better to leave this after that and then we can look into this config to keep packages separated. Or we can avoid this issue in the first place with #101 |
@achrafismyname This should be easier to fix now, no? |
I think so, I'll give it a try right now |
There seems to be something off with
@cura/hooks
withinStorybook
. It might come from theWebpack
config ofStorybook
. I temporarily ignored the stories with components that usehooks
.I could reproduce the error locally after cleaning
/node_modules
, but it seems to work out locally "sometimes", for example, if I tried to build after addinghooks
withyalc
and then removed it; that worked.More details in the
CI
build.The text was updated successfully, but these errors were encountered: