Error in CI deployment of Storybook for components with hooks

[bestatigen]

There seems to be something off with @cura/hooks within Storybook. It might come from the Webpack config of Storybook. I temporarily ignored the stories with components that use hooks.

I could reproduce the error locally after cleaning /node_modules, but it seems to work out locally "sometimes", for example, if I tried to build after adding hooks with yalc and then removed it; that worked.

More details in the CI build.

[sekaiking]

There is some problem with versioning, because when I run yarn add @cura/hooks, the package gets updated to 0.0.8 and everything works perfectly fine

package.json before

"@cura/hooks": "0.0.6",

package.json after yarn add @cura/hooks

"@cura/hooks": "^0.0.8",

https://www.npmjs.com/package/@cura/hooks is 0.0.8 and packages/hooks/packages.json is 0.0.6 which is a bit confusing, and i think it's the cause of the error you are getting.

[bestatigen]

I'm not sure that's the problem @achrafismyname. In #111 I tried all types of combinations. It seems to only happen with Storybook so will merge the PR and keep this one to fix it.

[sekaiking]

The problem

The problem here, is that yarn workspace is automatically linking the local package from packages\hooks and not getting @cura/hooks from npm repository.

And when we use @cura/hooks inside @cura/components, it tries to get it from packages\hooks\dist which doesn't exist by default.

Workarounds

• Make sure to build packages\hooks before running yarn storybook
• Doing yarn install--focus which forces yarn to get packages from npm repositery instead of the local folder. (more details)

I opened this PR below for now with a solution for CI. And added .yarnrc that automates the second workaround for when someone install the package

• Fix for CI deployment of Storybook for components with hooks #149

But I saw in #116 that @devey is working on upgrading yarn, so I think it's better to leave this after that and then we can look into this config to keep packages separated. Or we can avoid this issue in the first place with #101

[bestatigen]

@achrafismyname This should be easier to fix now, no?

[sekaiking]

I think so, I'll give it a try right now