Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address low-risk omniauth security issue #1903

Closed
mark-dce opened this issue Jun 4, 2019 · 2 comments
Closed

Address low-risk omniauth security issue #1903

mark-dce opened this issue Jun 4, 2019 · 2 comments

Comments

@mark-dce
Copy link
Contributor

mark-dce commented Jun 4, 2019

Follow the breadcrumbs here https://github.com/curationexperts/laevigata/network/alert/Gemfile.lock/omniauth/open

and here
omniauth/omniauth#809
omniauth/omniauth-rails#1

Determine whether there is any action needed on our part.

@bess bess self-assigned this Jun 4, 2019
@bess
Copy link

bess commented Jun 4, 2019

I took a swing at the omniauth security issue, but I don't think it's going to be a quick fix. See PR here: #1907.

This is not a new issue. It has been around since 2015, but a CVE was just issued for it, which is why it's suddenly on our radar. There will eventually be a better fix in place. I don't think we're particularly vulnerable, as first someone would have to compromise Emory's shibboleth server to take advantage of this. I recommend we wait until there is a straightforward fix available.

@bess bess changed the title Review omniauth security issue Address low-risk omniauth security issue Jun 4, 2019
@bess bess removed the high priority label Jun 4, 2019
@bess bess removed their assignment Jun 4, 2019
@mark-dce
Copy link
Contributor Author

Exploiting this vulnerability would require someone to

  1. breach emory's shibboleth system
  2. have access to an active session still open in another users browser

We think the likelihood of that (and the corresponding risk if it every did happen) is sufficiently low that we're closing out this issue for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants