Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use official builds for all platforms #49

Open
rubo opened this issue Dec 11, 2023 · 5 comments
Open

Use official builds for all platforms #49

rubo opened this issue Dec 11, 2023 · 5 comments

Comments

@rubo
Copy link

rubo commented Dec 11, 2023

Could we please have the official binaries by Facebook for all platforms?
The linkage to snappy and bz2 causes many problems on Linux, sometimes on macOS. Replacing those with ones from Facebook works as expected without having to install third-party packages and configure symlinks for some Linux distros. Furthermore, it will be more consistent to have all the binaries in the package from Facebook built the same way with no surprises on different platforms.

This is a major headache for us and I raised this a few times here and here but no action so far. Please reconsider this; otherwise, we will have to fork and maintain a separate package and that's just another burden for us.

Also, we can't use chiseled Docker images from Microsoft straight away without ugly workarounds because of those dependencies. Again, with Facebook builds, there's no problem.

@theolivenbaum
Copy link
Contributor

@rubo Just published a new version built with the official package libraries (except for windows, because for some reason the function names are exported weirdly in the java package).
image

I'll do a round of testing on our end to make sure these builds won't break anything, if that's the case we can switch to this permanently.

@rubo
Copy link
Author

rubo commented Jan 11, 2024

Thank you. Yeah, for Windows, they use this. Luckily, there's no need to install any dependency on Windows.

Please let us know when the package is available; we will also test it.

@chenjing1294
Copy link

I encounter a lot of errors when compiling and I don't know how to handle them. Can anyone provide a compiled Windows 64 dll?

@rubo
Copy link
Author

rubo commented Feb 1, 2024

@chenjing1294 Doesn't the DLL bundled in the NuGet package work for you?

@chenjing1294
Copy link

@rubo I forgot to introduce this, now it's back to normal

<PackageReference Include="RocksDbNative" Version="6.2.2" />

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants