From 2488f79e116d2e61a72ae61fc7c1ea7eee291a54 Mon Sep 17 00:00:00 2001 From: Michael Altamirano Date: Fri, 28 Jun 2019 12:21:02 -0700 Subject: [PATCH] Chore/update deprecation notices (#127) * Update SPACING constant deprecation notices * Update Button deprecation notices * Make SPACING language consistent with Button language --- src/constants/spacing/index.js | 16 ++++++++-------- .../button/components/roundButton/index.js | 2 +- src/shared-components/button/index.js | 2 +- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/constants/spacing/index.js b/src/constants/spacing/index.js index 333fb5979..96427654c 100644 --- a/src/constants/spacing/index.js +++ b/src/constants/spacing/index.js @@ -13,21 +13,21 @@ const SPACING = { const deprecatedProperties = { xxsmall: - 'SPACING.xxsmall is deprecated and will be removed in v3. Use SPACER.xsmall instead', + 'SPACING.xxsmall is deprecated and will be removed in a future major release. Use SPACER.xsmall instead', xsmall: - 'SPACING.xsmall is deprecated and will be removed in v3. Use SPACER.small instead', + 'SPACING.xsmall is deprecated and will be removed in a future major release. Use SPACER.small instead', small: - 'SPACING.small is deprecated and will be removed in v3. Use SPACER.medium instead', + 'SPACING.small is deprecated and will be removed in a future major release. Use SPACER.medium instead', base: - 'SPACING.base is deprecated and will be removed in v3. Use SPACER.large instead', + 'SPACING.base is deprecated and will be removed in a future major release. Use SPACER.large instead', medium: - 'SPACING.medium is deprecated and will be removed in v3. Use SPACER.xlarge instead', + 'SPACING.medium is deprecated and will be removed in a future major release. Use SPACER.xlarge instead', large: - 'SPACING.large is deprecated and will be removed in v3. Use SPACER.x2large instead', + 'SPACING.large is deprecated and will be removed in a future major release. Use SPACER.x2large instead', xlarge: - 'SPACING.xlarge is deprecated and will be removed in v3. Use SPACER.x4large instead', + 'SPACING.xlarge is deprecated and will be removed in a future major release. Use SPACER.x4large instead', xxlarge: - 'SPACING.xxlarge is deprecated and will be removed in v3. Use SPACER.x5large instead', + 'SPACING.xxlarge is deprecated and will be removed in a future major release. Use SPACER.x5large instead', }; export default withDeprecationWarning(SPACING, deprecatedProperties); diff --git a/src/shared-components/button/components/roundButton/index.js b/src/shared-components/button/components/roundButton/index.js index c618b19e6..0424ba863 100644 --- a/src/shared-components/button/components/roundButton/index.js +++ b/src/shared-components/button/components/roundButton/index.js @@ -18,7 +18,7 @@ const deprecatedProperties = { const isLoadingPropFunction = (props, propName, componentName) => { if (props[propName] !== undefined) { return new Error( - `'loading' prop will be deprecated in the next major release. Please rename 'loading' to 'isLoading' in ${componentName}` + `'loading' prop will be deprecated in a future major release. Please rename 'loading' to 'isLoading' in ${componentName}` ); } }; diff --git a/src/shared-components/button/index.js b/src/shared-components/button/index.js index af01cdfe6..187a62172 100644 --- a/src/shared-components/button/index.js +++ b/src/shared-components/button/index.js @@ -14,7 +14,7 @@ const deprecatedProperties = { const isLoadingPropFunction = (props, propName, componentName) => { if (props[propName] !== undefined) { return new Error( - `'loading' prop will be deprecated in the next major release. Please rename 'loading' to 'isLoading' in ${componentName}` + `'loading' prop will be deprecated in a future major release. Please rename 'loading' to 'isLoading' in ${componentName}` ); } };