Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing call to SetThreadContext #66

Closed
ifarbod opened this issue Mar 9, 2024 · 1 comment · Fixed by #67
Closed

Missing call to SetThreadContext #66

ifarbod opened this issue Mar 9, 2024 · 1 comment · Fixed by #67
Assignees
@cursey
Labels
bug Something isn't working

Comments

@ifarbod
Copy link

ifarbod commented Mar 9, 2024

In fix_ip, SetThreadContext is not called after fixing the thread's IP.

safetyhook/src/os.windows.cpp

Line 259 in 3f157c8

void fix_ip(ThreadContext thread_ctx, uint8_t* old_ip, uint8_t* new_ip) {

@cursey cursey mentioned this issue Mar 9, 2024
Merged
@cursey
Copy link
Owner

cursey commented Mar 9, 2024

Don't know how I missed that one. Thanks for the heads up. I have put in a PR could you please verify the issue is fixed. #67

@cursey cursey self-assigned this Mar 9, 2024
@cursey cursey added the bug Something isn't working label Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cursey cursey

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/Add missing SetThreadContext cursey/safetyhook
2 participants
@ifarbod @cursey