-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deep link is not working in ios, react native 0.71 #157
Comments
Hi @vanenshi We apologize for any inconvenience caused and appreciate you bringing this issue to our attention. We want to assure you that we are taking this matter seriously. Our team will conduct an internal investigation to determine the root cause of the issue and work towards resolving it. We will provide you with an update as soon as we have more information. In the meantime, please feel free to provide any additional information or details that you believe would be helpful in addressing this problem. |
I'd just like to add that I am also experiencing this issue - I've been in touch with support via email for a couple of weeks now and still can't get to the bottom of what's going on. Similar to @vanenshi we're able to validate that the payload received by the app contains the nested And we're able to validate that clicking a deep link on device correctly triggers @vanenshi can you add any clarity over what changes between 0.70 -> 0.71 you're referring to which might be coming in to play here? |
@djw27 Yes, we already had this feature working in version 2.0.0 and react native 70 (iOS) I am guessing that something break the deep like when we upgrade the package and react native |
Thanks for reporting this to us, @vanenshi. We are in the process of reproducing this issue ourselves and will get back to you on a fix. |
Thank you again for reporting this issue to us. We have been able to reproduce the issue in a React Native app (without any 3rd party push dependencies installed) and did some debugging of the Customer.io SDK. We have identified some ways that we could improve this issue of handling deep links when the app is killed/closed. It seems as though handling of deep links when an app is killed is a known and common problem in React Native with various ways to solve the problem. We are going to talk as a team to figure out how we would like to help customers around this limitation. In the mean time, I suggest reviewing what other React Native developers are doing to get around this issue. Your |
@vanenshi we are running RN 0.71 and have something like the following in our
|
@vanenshi final update from me on this - we realised that we were running into this issue because we had the This may or may not be the case for you (another Push Notification library installed) - but may help any future readers. We ended up with something similar to this:
|
@djw27 |
If CustomerIO came with local notifications, we'd switch to completely using CustomerIO. Dropping this here as feedback, but I recognize that it might not be a small feat to implement that :) |
Thank you all for your feedback and insights. This issue arises due to lifecycle differences between React Native and the native module when the app is in a killed state. We have documented this issue along with a workaround in our troubleshooting guide here. I am closing this ticket for now. Please feel free to add new comments or reopen it if needed. We would be happy to help. |
Thanks guys, aside from the problem you mentioned, we also had another problem that I also fixed in the boilerplate we used. I'll leave the PR here for anybody needs it |
SDK version: 2.4.2
Environment: Development
Are logs available? No
Describe the bug
The instructions in this link are for react native version 70. and in the 71 they totally change the
didFinishLaunchingWithOptions
. without this fix, deep links not working at all, and the following code never get called:To Reproduce
Additional context
this is the current code in react native 0.71
The text was updated successfully, but these errors were encountered: