Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to adapt code around v8 changes? #87

Closed
mikemorris opened this issue Feb 20, 2015 · 4 comments
Closed

How to adapt code around v8 changes? #87

mikemorris opened this issue Feb 20, 2015 · 4 comments
Labels

Comments

@mikemorris
Copy link
Contributor

Currently using UV_VERSION_MAJOR and UV_VERSION_MINOR as a hacky stopgap - what would be the proper way to do this? I'm specifically running into trouble around v8::UniquePersistent, which isn't in NAN yet.

Curious as to your current techniques re nodejs/node-v0.x-archive#5789 @springmeyer

The NAN defines like NODE_0_10_MODULE_VERSION don't seem to be available to me for some reason, should I use NODE_MODULE_VERSION or NODE_VERSION_AT_LEAST(major, minor, patch)?

https://github.com/joyent/node/blob/master/src/node_version.h
https://github.com/iojs/io.js/blob/v1.x/src/node_version.h

@ljbade
Copy link
Contributor

ljbade commented Feb 23, 2015

Just define another macro that simplifies the check by using one of the more complex macros.

@mikemorris
Copy link
Contributor Author

mapbox/node-pre-gyp@a859ec5 looks like it could provide some guidance here, refs mapbox/node-pre-gyp#150

@springmeyer
Copy link
Contributor

don't see that as related @mikemorris

@mikemorris
Copy link
Contributor Author

Simply needed to #include <node_version.h> to check NODE_MODULE_VERSION.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants