Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[security/privacy] new user can access a complete list of users via API call #2708

Closed
2 tasks done
alx- opened this issue Jan 22, 2021 · 3 comments · Fixed by #3788
Closed
2 tasks done

[security/privacy] new user can access a complete list of users via API call #2708

alx- opened this issue Jan 22, 2021 · 3 comments · Fixed by #3788
Assignees
Labels
enhancement New feature or request

Comments

@alx-
Copy link

alx- commented Jan 22, 2021

My actions before raising this issue

Expected Behaviour

GET /api/v1/users should not return a complete list of users

Current Behaviour

2021-01-23 00_35_55-User List – Django REST framework

I realize that this end-point is used somewhere for username autocompletion. But even though there is not a lot of info there (just id, login, first name and last name), it just seems very wrong to me.

@nmanovic
Copy link
Contributor

@alx- , on github you can see the full list of users. Does it look wrong as well? As a regular user you can see reduced information about all others. We need to support teams, but for now it is the only way to collaborate with other users.

@nmanovic nmanovic added the question Further information is requested label Jan 25, 2021
@alx-
Copy link
Author

alx- commented Jan 25, 2021

AFAIK, there is no way to just dump a list of all github users via official API. Also github users may opt not to include their full name in user profile.

Maybe it's somehow OK for cvat.org, though as someone who registered to test it, I find it not OK at all (that's why I didn't use my real name).

For some real-life deployments it could be disastrous. Right now anyone with a link can register, confirm e-mail and get a complete list of all users on this installation.

@nmanovic
Copy link
Contributor

@alx- , let's think how to resolve the issue. Probably when we add teams/groups, it will be easy to address.

@nmanovic nmanovic added enhancement New feature or request and removed question Further information is requested labels Jan 25, 2021
@nmanovic nmanovic added this to the Backlog milestone Jan 25, 2021
@nmanovic nmanovic self-assigned this Jul 29, 2021
@nmanovic nmanovic removed this from the Backlog milestone Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants