Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor dataset_repo app on server to use DRF and OPA #4386

Closed
2 tasks done
nmanovic opened this issue Feb 25, 2022 · 2 comments
Closed
2 tasks done

Refactor dataset_repo app on server to use DRF and OPA #4386

nmanovic opened this issue Feb 25, 2022 · 2 comments
Assignees
@Marishka17
Labels
enhancement New feature or request

Comments

@nmanovic
Copy link
Contributor

My actions before raising this issue

Possible Solution

At the moment REST API for dataset_repo doesn't correspond our guidelines: https://github.com/openvinotoolkit/cvat/blob/eac5b60d9b3b316d1ec7875b5a525813d507ab87/cvat/apps/dataset_repo/urls.py#L11

Also it is not protected by IAM: https://github.com/openvinotoolkit/cvat/blob/eac5b60d9b3b316d1ec7875b5a525813d507ab87/cvat/apps/dataset_repo/views.py#L39. In many cases only logic_required decorator is used and some functions use old permissions system (which was deleted).
@nmanovic nmanovic added the enhancement New feature or request label Feb 25, 2022
@nmanovic
Copy link
Contributor Author

@Marishka17 , refactoring of REST API need to start from the issue.

@nmanovic nmanovic mentioned this issue Feb 25, 2022
Merged
8 tasks
@bsekachev
Copy link
Member

The app was removed, not relevant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Marishka17 Marishka17

Labels
enhancement New feature or request
Projects
Server and REST API
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bsekachev @nmanovic @Marishka17