Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polygon editor does not open #602

Closed
raunilillemets opened this issue Jul 31, 2019 · 14 comments
Closed

Polygon editor does not open #602

raunilillemets opened this issue Jul 31, 2019 · 14 comments
Labels
bug Something isn't working

Comments

@raunilillemets
Copy link

Hello, according to the manual (section "annotation with polygons") it is possible to edit the polygon after completing it by double-clicking with pressed Shift.

However, if I hover over the polygon and double-click with pressed Shift, the polygon editor does not open. Instead, the zoom level is reset to the default zoom level.

CVAT version is 0.5

@raunilillemets
Copy link
Author

Further testing showed that this is show specific to my computer/browser (Google Chrome version 75.0.3770.142). In incognito mode and a colleague's computer the functionality worked perfectly. Disabling all extensions and cleaning cache did not help.

Since there is no way that any of the CVAT developers can re-produce this, I think that this issue needs to be closed (unless I can find more information about why this happens on my computer).

@bsekachev
Copy link
Member

@raunilillemets
This is interesting issue. As far as I known your case is the second. We have came across to this issue once before and we also didn't find the reason, just used incognito mode.

@bsekachev
Copy link
Member

@raunilillemets
I believe it should be investigated. But we couldn't reproduce it, so, I just don't know what to do.

@nmanovic nmanovic added the bug Something isn't working label Aug 2, 2019
@nmanovic nmanovic added this to the Backlog milestone Aug 2, 2019
@nmanovic
Copy link
Contributor

nmanovic commented Aug 2, 2019

@raunilillemets , @bsekachev , let's keep the bug for a while. I hope to hear more from our community how to reproduce it.

@FCollaPi
Copy link

I am facing a similar issue. The first time I try shift + double click it works just fine. The second time the polygon I am trying to edit goes hidden (radio button keeps the same but it has to be double clicked for the object to go visible again). Then the third time I try it the zoom is reset. I can only make it work again by refreshing the page but then the bug loop restarts.

CVAT is version 3.2.0.

docker-compose version 1.25.4, build unknown
docker-py version: 4.2.0
CPython version: 3.5.2
OpenSSL version: OpenSSL 1.0.2g 1 Mar 2016

Google Chrome Version 79.0.3945.130 (Official Build) (64-bit)

@bsekachev
Copy link
Member

@FCollaPi Sounds like another issue. In your case probably there are some exceprtions in the browser console, aren't they? Anyway, I would recommend you update CVAT because the version 3.2 is rather old

@FCollaPi
Copy link

@bsekachev Yes, I am getting this error:

cd88c77a0c88.js:15050 Uncaught TypeError: Cannot read property 'mousedown' of undefined at Function.SVG.off (cd88c77a0c88.js:15050) at initializer.off (cd88c77a0c88.js:15097) at initializer.draggable (cd88c77a0c88.js:17849) at PolygonView._makeNotEditable (eda1cbda7f00.js:5563) at PolygonView._makeNotEditable (eda1cbda7f00.js:6912) at PolygonView.onShapeUpdate (eda1cbda7f00.js:6483) at PolygonView.onShapeUpdate (eda1cbda7f00.js:6944) at PolygonModel.notify (eda1cbda7f00.js:1281) at PolygonModel.notify (eda1cbda7f00.js:4069) at PolygonModel.set active [as active] (eda1cbda7f00.js:4379) SVG.off @ cd88c77a0c88.js:15050 off @ cd88c77a0c88.js:15097 draggable @ cd88c77a0c88.js:17849 _makeNotEditable @ eda1cbda7f00.js:5563 _makeNotEditable @ eda1cbda7f00.js:6912 onShapeUpdate @ eda1cbda7f00.js:6483 onShapeUpdate @ eda1cbda7f00.js:6944 notify @ eda1cbda7f00.js:1281 notify @ eda1cbda7f00.js:4069 set active @ eda1cbda7f00.js:4379 resetActive @ eda1cbda7f00.js:9091 resetActive @ eda1cbda7f00.js:9746 (anonymous) @ eda1cbda7f00.js:9890 handle @ cd88c77a0c88.js:23821 dispatch @ cd88c77a0c88.js:23468 elemData.handle @ cd88c77a0c88.js:23276

Regarding the version, I installed CVAT following the guide on https://github.com/opencv/cvat/blob/develop/cvat/apps/documentation/installation.md just yesterday from develop branch. Is there any way to get a more recent one?

@FCollaPi
Copy link

Correction: I was getting the version in a wrong way. Opening About tab I get

Server version: 0.6

Core version: 0.5.2

Canvas version: 0.5.2

UI version: 0.5.2

@bsekachev
Copy link
Member

@FCollaPi

Can you provide steps to reproduce the issue?

@FCollaPi
Copy link

@bsekachev

I am facing a similar issue. The first time I try shift + double click it works just fine. The second time the polygon I am trying to edit goes hidden (radio button keeps the same but it has to be double clicked for the object to go visible again). Then the third time I try it the zoom is reset. I can only make it work again by refreshing the page but then the bug loop restarts.

@bsekachev
Copy link
Member

@FCollaPi

Okay, I checked it.
I get a bit other exceptions:

Uncaught TypeError: Cannot read property 'drawstart' of undefined
    at Function.SVG.off (svg.js:3493)
    at initializer.off (svg.js:3521)
    at PolyshapeEditorView._endEdit (polyshapeEditor.js:430)
    at PolyshapeEditorView.onPolyshapeEditorUpdate (polyshapeEditor.js:457)
    at PolyshapeEditorModel.notify (listener.js:48)
    at PolyshapeEditorModel.cancel (polyshapeEditor.js:83)
    at PolyshapeEditorModel.finish (polyshapeEditor.js:63)
    at PolyshapeEditorController.finish (polyshapeEditor.js:108)
    at initializer.<anonymous> (polyshapeEditor.js:405)
SVG.off @ svg.js:3493
off @ svg.js:3521
_endEdit @ polyshapeEditor.js:430
onPolyshapeEditorUpdate @ polyshapeEditor.js:457
notify @ listener.js:48
cancel @ polyshapeEditor.js:83
finish @ polyshapeEditor.js:63
finish @ polyshapeEditor.js:108
(anonymous) @ polyshapeEditor.js:405
[Violation] 'mousedown' handler took 1797ms
polyshapeEditor.js:426 Uncaught TypeError: Cannot read property 'remove' of null
    at PolyshapeEditorView._endEdit (polyshapeEditor.js:426)
    at PolyshapeEditorView.onPolyshapeEditorUpdate (polyshapeEditor.js:457)
    at PolyshapeEditorModel.notify (listener.js:48)
    at PolyshapeEditorModel.cancel (polyshapeEditor.js:83)
    at PolyshapeEditorModel.finish (polyshapeEditor.js:63)
    at annotationUI.js:228
    at logger.js:455
    at _fireCallback (mousetrap.js:616)
    at Mousetrap.self._handleKey (mousetrap.js:677)
    at Mousetrap.handleKey (mousetrap.js:994)

But behavior looks to be similar.

@bsekachev
Copy link
Member

@FCollaPi

This PR should help: #1212

@FCollaPi
Copy link

@bsekachev It's working! Thank you

@bsekachev
Copy link
Member

Let's close the issue. In new UI probably it is not a problem. Do not hesitate reopen if you still experience it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants