[GSoC2024] add return types to fix typescript warnings

[tahamukhtar20]

Fixes: #7598

Motivation and context

There are some minor typescript errors in the files, this pull request fixes those.

How has this been tested?

Ran the code after changing, and it was functional like before, this didn't need any additional test.

Checklist

• I submit my changes into the develop branch
• I have created a changelog fragment
• I have linked related issues (see GitHub docs)
  (cvat-canvas,
  cvat-core,
  cvat-data and
  cvat-ui)

License

• I submit my code changes under the same MIT License that covers the project.
  Feel free to contact the maintainers if that's a concern.

[tahamukhtar20]

I think this PR is not ready yet, there are a few changes which I just realized need to be added, I'll add those and ping you accordingly, thanks.

[codecov]

Codecov Report

Merging #7689 (8f352a8) into develop (02889ee) will increase coverage by 0.01%.
The diff coverage is 75.00%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #7689      +/-   ##
===========================================
+ Coverage    83.36%   83.37%   +0.01%     
===========================================
  Files          373      373              
  Lines        39722    39722              
  Branches      3747     3747              
===========================================
+ Hits         33113    33118       +5     
+ Misses        6609     6604       -5     

Components	Coverage Δ
cvat-ui	79.23% <75.00%> (+0.03%)	⬆️
cvat-server	87.21% <ø> (-0.01%)	⬇️

[SpecLad]

This fix has no impact on the user, so I don't think it needs a changelog entry.

[bsekachev]

Hello, do you have any plans regarding the pull request?

[tahamukhtar20]

Yes @bsekachev , I left a comment above under your review, please let me know. Thanks.

[bsekachev]

Yes, one week ago you mentioned "tomorrow". That is why I am asking :)

[tahamukhtar20]

Yes, one week ago you mentioned "tomorrow". That is why I am asking :)

Sorry about that, @bsekachev I wanted to ask something about your comment under the Promise review, you said we should use something more concrete here instead of any, but that is Lambda manager, and we are very uncertain what will be returned here, hence doesn't any make sense here?

[bsekachev]

I believe we are certain enough. Otherwise how would it be possible to work with this API?
As far as I remember run() returns a string, representing rq identificator to fetch automatic annotation statuses later.

call() is more complex, but, more or less, you may find it out from this file cvat-ui/src/components/annotation-page/standard-workspace/controls-side-bar/tools-control.tsx.

Perhaps the output is different for trackers, detectors and interactors.
So, it should be like Promise<TrackerResults | DetectorResults | InteractorResults>, and define these three types additionally.

[tahamukhtar20]

Hi @bsekachev, I've added the required types and currently added the interfaces on top of the Lambda Manager file, please let me know if that is fine or if there is some other place more appropriate for the interfaces.
Additionally, I have updated the concerned code related to the lambda.call function, but I had to make some type assertions(e.g. number[] and number[][] in the tools-control.tsx file) to make it work with the existing code without making too many changes. Please let me know if this is the correct implementation for this.
Thank you.

[bsekachev]

Please, avoid changes in tools-control.tsx, I will work with types inconsistency on my own, I see there are some issues.

[tahamukhtar20]

@bsekachev Updated

[bsekachev]

Just FYI: #7785

[tahamukhtar20]

I found some more typescript warnings because of missing return types, maybe I can create a follow-up pull request for this if you allow it.