Remove the quality parameter from lambda function call endpoints
#8683
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThis pull request implements a significant change in the handling of image quality within the system, specifically removing the ability to execute lambda functions on compressed images. The Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
SpecLad
force-pushed
the
remove-lambda-quality
branch
from
cf9e35e
to
aa45b09
Compare
1. In practice, it is never used by the UI. 2. In theory, I don't think it should be provided either. I don't think it ever makes sense for a user to want to run a function on a reduced-quality image, unless it just doesn't work on the original one (e.g. if it is too big). And in this case, CVAT should just perform the recompression automatically instead of making the user do it.
SpecLad
force-pushed
the
remove-lambda-quality
branch
from
aa45b09
to
3f73d51
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8683 +/- ##
===========================================
- Coverage 74.20% 74.19% -0.01%
===========================================
Files 401 401
Lines 43504 43496 -8
Branches 3950 3950
===========================================
- Hits 32280 32273 -7
+ Misses 11224 11223 -1
|
Motivation and context
In practice, it is never used by the UI.
In theory, I don't think it should be provided either. I don't think it ever makes sense for a user to want to run a function on a reduced-quality image, unless it just doesn't work on the original one (e.g. if it is too big). And in this case, CVAT should just perform the recompression automatically instead of making the user do it.
How has this been tested?
Checklist
developbranch[ ] I have updated the documentation accordingly[ ] I have linked related issues (see GitHub docs)[ ] I have increased versions of npm packages if it is necessary(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.
Summary by CodeRabbit
New Features
Bug Fixes
qualityparameter from various functionalities, streamlining image processing operations.Tests
qualityparameter, ensuring alignment with the new image handling process. Added tests for organizational permissions for invoking lambda functions.