Feature/support and hint for ttgo v2 board #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added hint to connect LORA_IO1 to GPIO33 for LMIC to work
cyberman54
requested changes
Feb 27, 2023
| @@ -126,6 +127,11 @@ upload_protocol = custom | |||
|
|
|||
| [env:usb] | |||
| upload_protocol = esptool | |||
| upload_speed = 921600 | |||
There was a problem hiding this comment.
This setting is global, for all type boards. Thus, we can't have this here, because some older boards do not support high upload speed. Please remove.
| @@ -126,6 +127,11 @@ upload_protocol = custom | |||
|
|
|||
| [env:usb] | |||
| upload_protocol = esptool | |||
| upload_speed = 921600 | |||
| monitor_speed = 115200 | |||
There was a problem hiding this comment.
why did you move this from section common to here?
| @@ -375,7 +375,7 @@ void dp_refresh(bool nextPage) { | |||
| dp_clear(); | |||
| break; | |||
| #else // skip this page | |||
| DisplayPage++; | |||
| DisplayPage = 0; | |||
There was a problem hiding this comment.
This seems like a hack aorund a bug to me. I think the bug is in display.h:
#define DISPLAY_PAGES (7) // number of paxcounter display pages Please try with (6). That should work.
| @@ -1,6 +1,7 @@ | |||
| ; ---> SELECT ONE TARGET BOARD FROM FOLLOWING ROWS <--- | |||
| ; | |||
| ; Note: For "LILYGO TTGO ESP32-Paxcounter LoRa32 V2.1 1.6.1" select board ttgov21new.h | |||
| ; Note: For "LILYGO TTGO ESP32-Paxcounter LoRa32 V2.0 1.6.0" select board ttgov2.h and add bodge wire from LORA_IO1 to GPIO33 | |||
There was a problem hiding this comment.
Please move this hint to ttgov2.h, since it's board specific.
cyberman54
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.