Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conditions for determining whether an event is included #11

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

zeroalphat
Copy link
Contributor

@zeroalphat zeroalphat commented Oct 16, 2023

Until now, after executing perf record, necoperf checked whether the cpu-clock event was included in the perf.data file to confirm that the sample was acquired correctly.
However, when perf record was executed on the actual device, cycles events were recorded in the perf.data file instead of cpu-clock events, and necoperf could not correctly determine whether the sample was acquired.
To correct this bug, I changed the condition in the part that checks if the event is included.

Signed-off-by: zeroalphat <taichi-takemura@cybozu.co.jp>
Copy link
Contributor

@morimoto-cybozu morimoto-cybozu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zeroalphat zeroalphat merged commit f3657b5 into main Oct 17, 2023
3 checks passed
@zeroalphat zeroalphat deleted the fix-cpu-event branch October 17, 2023 07:37
@zeroalphat zeroalphat added the bug Something isn't working label Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants