@quest-bot loot #147

Quest PR submitted!

@naineel1209, you are attempting to solve the issue and loot this Quest. Will you be successful?

Questions? Check out the docs.

Hey @petar-cvit, could you take a look at this and suggest any changes, if any?

@naineel1209, thanks for the PR.

However, I wouldn't have a separate table for replicasets, because Kubernetes will by retain the last 10 replicasets of a deployment

Can we just add a progress bar to the existing pods table that would indicate how many pods are created from each replicaset. For example, if the rollout is in progress and 2 pods are managed from the old replicaset, and 3 are managed from the new one, then 2/5 of the progress bar would be blue (for old pods) and 3/5 is green

Hi @petar-cvit , I’ve updated the ReplicaSet structure to display as a progress bar (check the PR comment for screenshots). The green section represents available pods from the active ReplicaSet, while the blue section shows available pods from non-active ReplicaSets.

Currently, I’m identifying the active ReplicaSet by sorting the list received in the response, using the number of replicas (in descending order) and creation time (in ascending order). If this approach is not favorable, could you suggest any alternative strategies for determining the active ReplicaSet?

@naineel1209 Looks awesome! You can actually find the latest replica in the status.conditions fro a condition of type Progressing and parse the replicaset name from the message. More info on deployment status here. From there, you can check which pods are managed from this replicaset.

I would prefer we infer it from here, not to call the k8s API once more to not bloat the endpoint.

From the UI standpoint, I would remove the numbers on the right since those are not accurate in some cases

Also, I just stumbled upon this issue where pods are still pending and the progressbar is saying 1 active / 1 non-active / 2 total

Hi @petar-cvit, As per the suggestions, In the BE, I've added a new field, activeReplicaSet, in the mapDeployment method which returns us the active ReplicaSet. In the FE, I've added a check to find the active ReplicaSet from the ReplicaSet list. Additionally, I've removed the text on the right to the progress bar and replaced it with a <SyncOutlined spin /> while the replicaset is progressing and <CheckCircleOutlined /> when replicaset is completed, to provide the users with some visual feedback.

Screenshots

@naineel1209 at first, it looked good, but when I restarted a deployment that specified 4 pods, and during rollout, there were six pods (2 from the new replicaset and four from the old one), the progress bar said 3 total, which doesn't match.

Can we make the desired number of replicas in deployment the total, and the green part would tell you how many replicas from the latest replicaset are healthy. If the pods of the new replicaset are unhealthy, they will still show blue.

Also, I would suggest that we don't query for replicasets separately but that we get it from the existing pods. Each pod will have a reference to its replicaset, so we don't have to ask K8s API for it. From there, you can just calculate (number of healthy pods) / (number of desired replicas in the deployment)