Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tooltip to resource not needed warning #644

Open
KaradzaJuraj opened this issue Oct 21, 2024 · 11 comments
Open

Add tooltip to resource not needed warning #644

KaradzaJuraj opened this issue Oct 21, 2024 · 11 comments
Labels
good first issue Good for newcomers hacktoberfest ⚔️ Quest Tracks quest-bot quests react typescript UI Update on the UI

Comments

@KaradzaJuraj
Copy link
Collaborator

KaradzaJuraj commented Oct 21, 2024

Move the warning sign next to the resource name and status. Add a tooltip when hovering over the warning icon that displays “This resource is not used by the module anymore and can be deleted.”

To get the warning sign, you can use the demo template:

  1. deploy it with the service toggled on
  2. Edit the module and toggle the service off
  3. now you will have the warning sign on the service
@quest-bot quest-bot bot added the ⚔️ Quest Tracks quest-bot quests label Oct 21, 2024
Copy link

quest-bot bot commented Oct 21, 2024

New Quest! image New Quest!

A new Quest has been launched in @cyclops-ui’s repo.
Merge a PR that solves this issue to loot the Quest and earn your reward.


Some loot has been stashed in this issue to reward the solver!

🗡 Comment @quest-bot embark to check-in for this Quest and start solving the issue. Other solvers will be notified!

⚔️ When you submit a PR, comment @quest-bot loot #644 to link your PR to this Quest.

Questions? Check out the docs.

@cyclops-ui cyclops-ui deleted a comment from ArnavK-09 Oct 21, 2024
@ArnavK-09
Copy link
Contributor

can you specify location?

"next"

image

@ArnavK-09
Copy link
Contributor

@quest-bot embark

Copy link

quest-bot bot commented Oct 21, 2024

@ArnavK-09 has embarked on their Quest. 🗡

  • @ArnavK-09 has been on GitHub since 2020.
  • They have merged 126 public PRs in that time.
  • Their swords are blessed with TypeScript and CSS magic ✨
  • They have contributed to this repo before.

This is not an assignment to the issue. Please check the repo’s contribution guidelines before submitting a PR.

Questions? Check out the docs.

@ArnavK-09
Copy link
Contributor

Move the warning sign next to the resource name and status.

and do i have to remove warning signs from here?

image

@KaradzaJuraj
Copy link
Collaborator Author

Hey @ArnavK-09, you currently already have two PRs open. Please finish those before starting new issues.

@ArnavK-09
Copy link
Contributor

can you review em

@AkashJana18
Copy link

@quest-bot embark

Copy link

quest-bot bot commented Oct 30, 2024

@AkashJana18 has embarked on their Quest. 🗡

  • @AkashJana18 has been on GitHub since 2022.
  • They have merged 22 public PRs in that time.
  • Their swords are blessed with Shell and Dockerfile magic ✨
  • They haven't contributed to this repo before.

This is not an assignment to the issue. Please check the repo’s contribution guidelines before submitting a PR.

Questions? Check out the docs.

@AkashJana18
Copy link

Hey @KaradzaJuraj,

I’m working on moving the warning sign next to the resource name and status, with a tooltip that displays “This resource is not used by the module anymore and can be deleted.” I’d appreciate a few clarifications to ensure it’s implemented accurately:

  1. Positioning of Warning Sign: Could you specify the exact placement of the warning icon relative to the resource name and status? For example, should it appear on the left, right, or directly adjacent to the status text?

  2. Tooltip Trigger: Should the tooltip appear when hovering over just the warning icon, or would you like it to also trigger when hovering over the resource name and status?

  3. Warning Sign Activation: After deploying the demo template with the service toggled on and then toggling it off, should the warning icon only appear when the module recognizes that the resource is unused, or immediately upon toggling off?

  4. Styling Preferences: Are there any specific styles or design elements for the warning icon that need to match other UI components, or should it follow the default warning icon style?

Thank you for the additional guidance!

@KaradzaJuraj
Copy link
Collaborator Author

Hey @AkashJana18

  1. To the right of the name and status
  2. Trigger only when hovering over the warning sign
  3. When the module recognizes that the resource is unused (but shouldn't matter in this issue)
  4. Use the same warning icon that is used now

I hope this clears things up; if you have any other questions - reach out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest ⚔️ Quest Tracks quest-bot quests react typescript UI Update on the UI
Projects
None yet
Development

No branches or pull requests

3 participants