Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task messages should be recorded in suite DBs. #1490

Closed
hjoliver opened this issue Jun 9, 2015 · 5 comments
Closed

Task messages should be recorded in suite DBs. #1490

hjoliver opened this issue Jun 9, 2015 · 5 comments
Assignees
Milestone

Comments

@hjoliver
Copy link
Member

hjoliver commented Jun 9, 2015

(currently they're not).

@hjoliver hjoliver added this to the soon milestone Jun 9, 2015
@matthewrmshin
Copy link
Contributor

@hjoliver I am currently in the middle of adding some new tables and doing some refactor to cylc.rundb. Please let me know the kind of things you would like to add.

@hjoliver
Copy link
Member Author

hjoliver commented Jun 9, 2015

@matthewrmshin - are you working on #864? I'll attempt to put a bit of thought into this tomorrow...

@matthewrmshin
Copy link
Contributor

Not really. I am mainly working on #992 (and by extension #1052).

@benfitzpatrick
Copy link
Contributor

E.g. cylc message -p WARN 'Oh no!' to be recorded in the suite database.

@benfitzpatrick benfitzpatrick modified the milestones: later, soon Jun 13, 2016
@hjoliver
Copy link
Member Author

hjoliver commented Jun 14, 2016

Non-output task messages can be sent with NORMAL, WARNING, or CRITICAL priority. This might seem a more-or-less useless feature. Thinking back, the intention was to log all messages in case of typos that caused output messages not to be recognized as outputs, and to allow deliberate recording of task errors centrally back when task job logs were not so easily accessed. There is probably little need for this now (although the first reason is still valid) but given that we do support such messages they should really be recorded in the DB as well as logged. Easy to do - the "message" column in the task_events table is already used for message outputs.

Changing the Issue title to "all messages" as there's no reason to single out WARNINGs...

@hjoliver hjoliver changed the title Task warning messages should be recorded in the suite run-db. Task messages should be recorded in suite DBs. Jun 14, 2016
@matthewrmshin matthewrmshin modified the milestones: next release, later Jun 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants