Cylc log dropdown forgets old logs upon re-insertion of old tasks

[GlennCreighton]

When reinserting a task that has already been removed, I'm finding that the log dropdown no longer functions as expected. The dropdown only includes the log for job 1 and the new job's log cannot be viewed. This occurs with Cylc 7.7.1.

[hjoliver]

Reproduced. After re-insertion, the job try number continues to increment correctly, but doesn't get displayed correctly in the GUI job log viewer.

[matthewrmshin]

The bug starts here:
https://github.com/cylc/cylc/blob/f99193f3eb7aae00f3e4ff7e708ace54e4ae9ea6/lib/cylc/gui/app_gcylc.py#L2208

The length of the dict may not be the same as the maximum value of the dict keys, because there may be missing submits, like in this case.

[GlennCreighton]

This also appears to happen after restarting the suite.

[matthewrmshin]

There is a secondary problem here. If the reinserted task is in the waiting state, visibility of the links to job file views in the right click menu is determined by the current task state - so even though the task may have been submitted(+run) before, the right click menu may not display the links to job files for previous submits.

[matthewrmshin]

@wxtim Can you please check whether #2830 fully fixes this issue or not?

[GlennCreighton]

i did a quick test and it looks like this fix does the trick. Thanks!

[wxtim]

I believe that this has fixed the issue. :)

[matthewrmshin]

Closed by #2830.