Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: install cypress via pnpm #5402

Merged
merged 4 commits into from
Aug 1, 2023

Conversation

inblossoms
Copy link
Contributor

This PR is related to #27419.

@netlify
Copy link

netlify bot commented Jul 31, 2023

👷 Deploy request for cypress-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit f4eb2a0

@CLAassistant
Copy link

CLAassistant commented Jul 31, 2023

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Jul 31, 2023

Deploy Preview for benevolent-cat-040f48 ready!

Name Link
🔨 Latest commit f4eb2a0
🔍 Latest deploy log https://app.netlify.com/sites/benevolent-cat-040f48/deploys/64c84c39a483210008ac752d
😎 Deploy Preview https://deploy-preview-5402--benevolent-cat-040f48.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress-app-bot
Copy link
Collaborator

@MikeMcC399

This comment was marked as outdated.

@inblossoms
Copy link
Contributor Author

inblossoms commented Jul 31, 2023

@MikeMcC399

ugh, I misinterpreted your meaning and submitted the PR.
Thank you again for pointing out the problem to me.
I wonder if I need to turn it off, but this PR might be useful for users like me.

@MikeMcC399

This comment was marked as resolved.

Correct the problem of incorrect symbol writing

Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
@inblossoms
Copy link
Contributor Author

uh-huh, Do I need to change it to 'pnpm install cypress --dev'? The 'pnpm install cypress --dev' approach is not desirable in my use. It is also because of this way of initializing Cypress that I submit this issue.
It is a good idea to provide the installation steps by tabbing or updating the video, maybe I can give it a try.
I may need to sign the CLA later, as you said, if I want this PR to be accepted.
(I have benefited a lot from talking with you.)

@MikeMcC399

This comment was marked as outdated.

@inblossoms
Copy link
Contributor Author

Installing cypress into package.json's devDependencies aligns to the Getting Started instructions for npm and yarn. Getting Started is not intended to cover all use cases though. Why was 'pnpm install cypress --dev' not right for you?

I don't know why, but it takes more than twenty minutes to install with 'pnpm install cypress -D' (as I recall), but only 10-20 seconds with npm. Moreover, the project completed by pnpm installation lost the test case, so I need to install the patch of the use case again for the test case.

@MikeMcC399

This comment was marked as outdated.

@MikeMcC399

This comment was marked as outdated.

@MikeMcC399

This comment was marked as outdated.

@inblossoms
Copy link
Contributor Author

pnpm install cypress --save-dev works, which conflicts with the pnpm documentation.

When I found that I could not install it correctly through 'pnpm', I wondered if it was related to the underlying implementation of pnpm.
Now I can stop caring so much about it.

@MikeMcC399
Copy link
Contributor

@inblossoms

Apologies for my confusion between pnpm add and pnpm install !
I need to review my comments now, since I got this wrong.

Let pnpm in line with the npm and yarn installs examples above
@inblossoms
Copy link
Contributor Author

Hi @MikeMcC399

add or install, I am very terrible at using pnpm. You're just trying to clear my mind. thanks for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants