From 374ceb20f95402a4f98d858d47307726dcc83102 Mon Sep 17 00:00:00 2001
From: Bill Glesias <bglesias@gmail.com>
Date: Tue, 21 May 2024 14:35:43 -0400
Subject: [PATCH] chore: change path created in prevous PR to make windows
 compliant (#29551)

empty commit to run ci [run ci]

squash this
---
 .circleci/workflows.yml                       |  2 +-
 .../test/integration/http_requests_spec.js    | 20 +++++++++++++++++--
 .../foo.txt"                                  |  0
 .../index.html"                               |  0
 4 files changed, 19 insertions(+), 3 deletions(-)
 rename "system-tests/projects/no-server/dev/_ :;.,\"'!(){}[]@<>=-+*$&`|~^\304\265\347\254\246/foo.txt" => "system-tests/projects/no-server/dev/_ ;.,'!(){}[]@=-+$&`~^\304\265\347\254\246/foo.txt" (100%)
 rename "system-tests/projects/no-server/dev/_ :;.,\"'!(){}[]@<>=-+*$&`|~^\304\265\347\254\246/index.html" => "system-tests/projects/no-server/dev/_ ;.,'!(){}[]@=-+$&`~^\304\265\347\254\246/index.html" (100%)

diff --git a/.circleci/workflows.yml b/.circleci/workflows.yml
index 6b6705686a38..ef5e360d8017 100644
--- a/.circleci/workflows.yml
+++ b/.circleci/workflows.yml
@@ -76,7 +76,7 @@ windowsWorkflowFilters: &windows-workflow-filters
     - equal: [ develop, << pipeline.git.branch >> ]
     # use the following branch as well to ensure that v8 snapshot cache updates are fully tested
     - equal: [ 'update-v8-snapshot-cache-on-develop', << pipeline.git.branch >> ]
-    - equal: [ 'feat/vite_5_support', << pipeline.git.branch >> ]
+    - equal: [ 'chore/fix_illegal_characters_in_windows', << pipeline.git.branch >> ]
     - matches:
         pattern: /^release\/\d+\.\d+\.\d+$/
         value: << pipeline.git.branch >>
diff --git a/packages/server/test/integration/http_requests_spec.js b/packages/server/test/integration/http_requests_spec.js
index 229574dd2be2..2b7651eb5835 100644
--- a/packages/server/test/integration/http_requests_spec.js
+++ b/packages/server/test/integration/http_requests_spec.js
@@ -3964,8 +3964,24 @@ describe('Routes', () => {
         })
       })
 
+      /**
+       * NOTE: certain characters cannot be used inside our own monorepo due to our system tests also needing to run
+       * inside Windows. The following are reserved characters:
+       *
+       * < (less than)
+       * > (greater than)
+       * : (colon)
+       * " (double quote)
+       * / (forward slash)
+       * \ (backslash)
+       * | (vertical bar or pipe)
+       * ? (question mark)
+       * * (asterisk)
+       *
+       * @see https://learn.microsoft.com/en-us/windows/win32/fileio/naming-a-file#naming-conventions for more details
+       */
       it('can serve files with special characters in the fileServerFolder path', async function () {
-        await this.setupProject({ fileServerFolder: `dev/_ :;.,"'!(){}[]@<>=-+*$&\`|~^ĵ符` })
+        await this.setupProject({ fileServerFolder: `dev/_ ;.,'!(){}[]@=-+$&\`~^ĵ符` })
 
         return this.rp({
           url: `${this.proxy}/foo.txt`,
@@ -3975,7 +3991,7 @@ describe('Routes', () => {
         })
         .then((res) => {
           expect(res.statusCode).to.eq(200)
-          expect(res.headers).to.have.property('x-cypress-file-path', encodeURI(`${Fixtures.projectPath('no-server')}/dev/_ :;.,"'!(){}[]@<>=-+*$&\`|~^ĵ符/foo.txt`))
+          expect(res.headers).to.have.property('x-cypress-file-path', encodeURI(`${Fixtures.projectPath('no-server')}/dev/_ ;.,'!(){}[]@=-+$&\`~^ĵ符/foo.txt`))
           expect(res.body).to.eq('foo')
         })
       })
diff --git "a/system-tests/projects/no-server/dev/_ :;.,\"'!(){}[]@<>=-+*$&`|~^\304\265\347\254\246/foo.txt" "b/system-tests/projects/no-server/dev/_ ;.,'!(){}[]@=-+$&`~^\304\265\347\254\246/foo.txt"
similarity index 100%
rename from "system-tests/projects/no-server/dev/_ :;.,\"'!(){}[]@<>=-+*$&`|~^\304\265\347\254\246/foo.txt"
rename to "system-tests/projects/no-server/dev/_ ;.,'!(){}[]@=-+$&`~^\304\265\347\254\246/foo.txt"
diff --git "a/system-tests/projects/no-server/dev/_ :;.,\"'!(){}[]@<>=-+*$&`|~^\304\265\347\254\246/index.html" "b/system-tests/projects/no-server/dev/_ ;.,'!(){}[]@=-+$&`~^\304\265\347\254\246/index.html"
similarity index 100%
rename from "system-tests/projects/no-server/dev/_ :;.,\"'!(){}[]@<>=-+*$&`|~^\304\265\347\254\246/index.html"
rename to "system-tests/projects/no-server/dev/_ ;.,'!(){}[]@=-+$&`~^\304\265\347\254\246/index.html"