Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf Investigation: Video Capture while spec is loading #21976

Closed
sync-by-unito bot opened this issue May 31, 2022 · 3 comments
Closed

Perf Investigation: Video Capture while spec is loading #21976

sync-by-unito bot opened this issue May 31, 2022 · 3 comments
Labels
stale no activity on this issue for a long period topic: video 📹 type: performance 🏃‍♀️ Performance related

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented May 31, 2022

Summary

Currently the video starts as soon as the browser opens, and ffmpeg eats up a ton of CPU. The webpack / esbuild preprocessor is also CPU intensive, so by nature of recording a video, it makes the time to initial test significantly slow, especially in component testing.

You can reproduce by running CT or E2E tests in run mode with/without video (--config video=false) and watch the CPU usage of the Cypress: Config Manager process and ffmpeg

There are also flags that we might be missing to help with the recording performance: https://github.com/microsoft/playwright/blob/5d8aa8d5cfdd6169c4eaad0ebaf53502f43de8df/packages/playwright-core/src/server/chromium/videoRecorder.ts#L59-L96

Acceptance Criteria

  • Come up with a reproducible example and benchmarks the time to start with/without video, and with a delay in starting the video
  • Determine if there are other flags we can use to reduce the overall cpu usage / speed up tests
  • Come up with proposals for what we can change based on this investigation, and if/how this will affect product

┆Issue is synchronized with this Jira Task by Unito
┆author: Tim Griesser
┆epic: Testing / Quality
┆friendlyId: UNIFY-985
┆priority: Low
┆sprint: Backlog
┆taskType: Task

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 31, 2022

➤ Jennifer Shehane commented:

Delaying the video recording is not in scope for the initial unification release.

@cypress-app-bot
Copy link
Collaborator

This issue has not had any activity in 180 days. Cypress evolves quickly and the reported behavior should be tested on the latest version of Cypress to verify the behavior is still occurring. It will be closed in 14 days if no updates are provided.

@cypress-app-bot cypress-app-bot added the stale no activity on this issue for a long period label Sep 19, 2023
@cypress-app-bot
Copy link
Collaborator

This issue has been closed due to inactivity.

@cypress-app-bot cypress-app-bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale no activity on this issue for a long period topic: video 📹 type: performance 🏃‍♀️ Performance related
Projects
None yet
Development

No branches or pull requests

2 participants