-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react18): unmount component with react18 API #23204
Conversation
Thanks for taking the time to open a PR!
|
}, | ||
} | ||
|
||
return makeUnmountFn(options, internalOptions) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file below this (_snapshots__
) has a surprisingly huge diff with a lot of red. Is this right? It seems to be missing the "summary" part of the CLI output.
I tried it out (build the new react modules and stuck them in an existing project's node_modules/cypress) and it's working great, nice job 💯 |
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Nice, second latest job went all green: https://app.circleci.com/pipelines/github/cypress-io/cypress?branch=zachw%2Ffix-react18-unmount Not sure why the info in the checkbox is showing red, maybe because I canceled the later build (due to the previous one passing). Let's ship it. |
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
User facing changelog
Additional details
Steps to test
npm/react
andnpm/react18
projectsdist
folders from the projects and place them in a React project under their respective React folders innode_modules/cypress
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?