Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest Vue version in monorepo #23909

Closed
lmiller1990 opened this issue Sep 21, 2022 · 2 comments · Fixed by #26555
Closed

Update to latest Vue version in monorepo #23909

lmiller1990 opened this issue Sep 21, 2022 · 2 comments · Fixed by #26555
Assignees
Labels
CT Issue related to component testing Triaged Issue has been routed to backlog. This is not a commitment to have it prioritized by the team.

Comments

@lmiller1990
Copy link
Contributor

Current behavior

I tried updating Vue (current on 3.2.31) and I noticed 3.2.32 causes this test to fail:

We rely on an unmounted component (Project Connect Modal) to emit an event emit('success') when it is unmounted. This was working in Vue 3.2.31, but apparently unintended, and was changed in this PR to Vue https://github.com/vuejs/core/pull/5679/files which broke us.

Relying on an unmounted component to do anything is definitely not ideal, so we will need to change how that part of the App works.

Desired behavior

N/A

Test code to reproduce

N/A

Cypress Version

N/A

Node version

N/A

Operating System

N/A

Debug Logs

N/A

Other

No response

@lmiller1990 lmiller1990 changed the title Update to Vue 3.2.39 Update to latest Vue version in monorepo Mar 8, 2023
@lmiller1990
Copy link
Contributor Author

@nagash77 nagash77 added CT Issue related to component testing Triaged Issue has been routed to backlog. This is not a commitment to have it prioritized by the team. and removed routed-to-ct labels Apr 19, 2023
@astone123 astone123 self-assigned this Apr 20, 2023
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 26, 2023

Released in 12.11.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.11.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Apr 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CT Issue related to component testing Triaged Issue has been routed to backlog. This is not a commitment to have it prioritized by the team.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants