Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IATR](M1.0) "Run Failures" button enhancements #24854

Closed
warrensplayer opened this issue Nov 28, 2022 · 4 comments
Closed

[IATR](M1.0) "Run Failures" button enhancements #24854

warrensplayer opened this issue Nov 28, 2022 · 4 comments
Assignees

Comments

@warrensplayer
Copy link
Contributor

warrensplayer commented Nov 28, 2022

Updates to the behavior of the "Run Failures" button in the DebugSpec component

  • Add a tooltip when the button is disabled that says "Spec was not found locally"

image

* Update disabled/enabled based on local polling * the existing logic that is being used to monitor changes in spec files will be used to drive the setting of the `isDisabled` prop for the component. Confirm with a test that changing the prop on an already mounted component will update the button/link
  • Show CTA in tooltip for switching testing types if needed
    • The isDisabled flag will also be false for a spec if the testing type for the spec does not match the current testing type for the Cypress app. Add a new flag to the component to let it know it needs to switch to a new testing type in order to run this test locally. Then show a different tooltip shown in the designs below.
    • If the App is in E2E mode and the test is a component test, and the local project is configured for component testing
      • Text: "There are {failedSpecCount} component tests failing in this spec. To run them locally, switch to component testing"
      • CTA: "Switch to component testing" - clicking the button should reload the app in the component testing mode
    • If the opposite situation:
      • Text: "There are {failedSpecCount} E2E tests failing in this spec. To run them locally, switch to E2E"
      • CTA: "Switch to E2E testing" - clicking the button should reload the app in the E2E testing mode

image

Clickup: https://app.clickup.com/t/18033298/PM-2546
Figma Flow

@warrensplayer warrensplayer changed the title [IATR](M1) "Run Specs" button enhancements [IATR](M1.0) "Run Specs" button enhancements Dec 1, 2022
@warrensplayer warrensplayer changed the title [IATR](M1.0) "Run Specs" button enhancements [IATR](M1.0) "Run Failures" button enhancements Dec 5, 2022
@warrensplayer
Copy link
Contributor Author

@ZachJW34 ZachJW34 self-assigned this Dec 15, 2022
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review stage: review and removed stage: in progress stage: needs review The PR code is done & tested, needs review labels Dec 20, 2022
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 22, 2022

The code for this is done in cypress-io/cypress#25234, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@lmiller1990
Copy link
Contributor

Closing since resolved in #25234

@emilyrohrbough
Copy link
Member

Released in 12.5.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.5.0, please open a new issue.

@cypress-io cypress-io locked as resolved and limited conversation to collaborators Jan 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants