Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component Testing: typescript ^=5.0.0 support #26204

Closed
1 of 6 tasks
OrbisK opened this issue Mar 23, 2023 · 5 comments · Fixed by #26413 or #26815
Closed
1 of 6 tasks

Component Testing: typescript ^=5.0.0 support #26204

OrbisK opened this issue Mar 23, 2023 · 5 comments · Fixed by #26413 or #26815
Assignees
@dkasper-was-taken
Labels
CT Issue related to component testing Triaged Issue has been routed to backlog. This is not a commitment to have it prioritized by the team. type: bug type: regression A bug that didn't appear until a specific Cy version release

Comments

@OrbisK
Copy link

OrbisK commented Mar 23, 2023 •
edited
Loading

Description

When I setup component testing typescript 5 is not detected as typescript.

URL of Issue(s)

https://docs.cypress.io/guides/component-testing/vue/quickstart

Steps to replicate

npm i typescript -D
npx cypress open

Browser

No response

Device

  • PC
  • Mac
  • iPhone
  • iPad
  • Android Phone
  • Android Tablet

Additional Information

No response
@OrbisK
Copy link
Author

OrbisK commented Mar 23, 2023

image

@emilyrohrbough emilyrohrbough transferred this issue from cypress-io/cypress-documentation Mar 23, 2023
@emilyrohrbough emilyrohrbough mentioned this issue Mar 23, 2023
Closed
3 tasks
@lmiller1990
Copy link
Contributor

Related: #26148

Might be fixed in #26173

@lmiller1990 lmiller1990 mentioned this issue Apr 4, 2023
Merged
3 tasks
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 17, 2023

Released in 12.10.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.10.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Apr 17, 2023
@marktnoonan
Copy link
Contributor

I'm going to re-open this one, I was setting up CT in a Next.js project for a friend this weekend and TS 5 was not detected as valid:

Screenshot 2023-05-16 at 10 10 34 AM

I just double checked against develop and it was the same. #26413 added support for this so I was surprised.

To reproduce: clone https://github.com/TechIsHiring/techishiring-website and attempt to setup component testing (you may need to remove the CT config if my PR was already merged there).

@marktnoonan marktnoonan reopened this May 16, 2023
@nagash77 nagash77 added type: regression A bug that didn't appear until a specific Cy version release CT Issue related to component testing Triaged Issue has been routed to backlog. This is not a commitment to have it prioritized by the team. labels May 16, 2023
@mike-plummer
Copy link
Contributor

In packages/scaffold-config/src/dependencies.ts, Typescript version string needs to have extra quotes removed:

'^=3.4.0 || ^=4.0.0' || '^=5.0.0'
should be
'^=3.4.0 || ^=4.0.0 || ^=5.0.0'

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dkasper-was-taken dkasper-was-taken

Labels
CT Issue related to component testing Triaged Issue has been routed to backlog. This is not a commitment to have it prioritized by the team. type: bug type: regression A bug that didn't appear until a specific Cy version release
Projects
None yet
Milestone
No milestone
6 participants
@nagash77 @marktnoonan @mike-plummer @lmiller1990 @dkasper-was-taken @OrbisK