-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firefox 124 + Cypress 13.7.1 The browser never connected. Something is wrong. The tests cannot run. Aborting... after first test with multiple tests on CI #29190
Comments
I tried to reproduce your issue using the repo https://github.com/cypress-io/cypress-example-kitchensink. The workflow I set up to use Firefox failed with Firefox I have a couple of comments which may or may not help:
|
#29172 was supposed to fix this issue on cypress
First test passes then second tests fails to connect to the browser:
I'll try to provide a minimal reproducible sample |
@MikeMcC399 May I request you to try again with firefox module.exports = {
// ... some config
e2e: {
// ... some config
// specify user agent:
userAgent: 'Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/114.0'
}
} For me it fails with the user agent string, and works when I remove it |
Your Firefox user agent string is not consistent with Firefox |
|
Are you also specifying Edit:
or something non-null. |
@MikeMcC399 from my expectation the user agent string itself shouldn't change how cypress behaves. We use it to make sure our app will detect that it's an unsupported browser during E2E, and I'm sure that other users will do the same. It's a lot faster than having to manage multiple firefox binaries when all we need is to change the UA string. I'm not even sure why cypress would allow us to change the UA string if it breaks cypress itself. Any chance we can expect a more solid support for firefox >124? |
Thanks for your explanation!
|
@MikeMcC399 I can definitely say we use a specific userAgent in our FF tests as well, making it break for us as well, only when running against CI (only because we only set this in the GH action workflow for the FF run)
@gsouf thanks for bringing this up! This was driving me insane |
looking at our history, we can probably just update the userAgent used to 124.0 in the custom config. Our issue appeared to be something around the |
I opted to use the We could likely pass in the binary version detected in the app at time of launch and forward that to the extension request, but that seemed somewhat involved and unnecessary. It can be done, but it would need to be baked into Cypress itself and it likely a lot easier to adapt your UA to include the version in which is being run. |
@AtofStryker thanks for the details. But knowing that does it make sense to expose the ability to change the user agent? It seems that as long as an user is specifying a UA it's potentially going to break the cypress runtime itself. For which use case, in the first place, does cypress allow users to configure a custom user agent? |
@gsouf Cypress allows the use of custom user agents. You should be able to change the user agent without being impacted. That currently does not work in this case, so we are exploring solutions where we don't rely on the user agent to interpret the version for the fix. Either we can forward the version from the binary, or we can apply the fix more broadly. I should be looking into this shortly! |
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Current behavior
After upgrading to 13.7.1 to fix the Firefox 124 issue, we confirmed that local runs of
open
andrun
work to run tests in Firefox with multiple specs synchronously.But, overnight on the Github CI workflow action, we are continuing to see failures on any jobs that have multiple specs for Firefox only. Our Github action uses
@cypress/github-actionsv5
with the followingOutput without debug showing the first test succeeding but the second test failing/aborting:
Chrome which runs on the same GH runner, same OS, using
@cypress/github-actionsv5
has no issuesDesired behavior
Running Cypress in Github Workflow against Firefox 124 with
@cypress/github-actionsv5
where multiple specs run synchronously worksTest code to reproduce
Should fail running against github action on FF124 using ubuntu image with multiple specs
Cypress Version
13.7.1
Node version
v16.20.2
Operating System
ubuntu-22.04
Debug Logs
Other
No response
The text was updated successfully, but these errors were encountered: