If anything but a number is passed as the timeout option on cy.get(), the test never reaches the failure state

[bernardodomingues-hotmart]

Current behavior

Passing something that is not a number to the timeout field causes what should be a failing test never to reach the failure state.

Desired behavior

If the option is not a valid number, ignore it and apply the default timeout (AFAIK 4s).

Test code to reproduce

https://github.com/bernardodomingues-hotmart/cypress-test-tiny

Cypress Version

13.7.3

Node version

v20.12.2

Operating System

macOS 13.6.6 / Docker cypress-included

Debug Logs

No response

Other

Even though we should have TS for type checking, old codebases are still in JS. This was caused by a developer error when creating custom commands, but there should be a safety net, as IMHO is better for a test to fail fast than never finish. This in a CI environment was a disaster :)

[cacieprins]

It may make the most sense here to throw a TypeError if a non-number timeout is supplied to any command, rather than falling back to the default timeout. What do you think?

[jennifer-shehane]

@bernardodomingues-hotmart We'd be open to a PR to handle this.

[sossost]

hi. @jennifer-shehane I am sossost, a new contributor. Can I fix this? thank you

[bernardodomingues-hotmart]

It may make the most sense here to throw a TypeError if a non-number timeout is supplied to any command, rather than falling back to the default timeout. What do you think?

I agree.

[cypress-bot]

Released in 13.8.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.8.1, please open a new issue.