Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Node 4 & 6 support from CLI #4200

Closed
bahmutov opened this issue May 15, 2019 · 6 comments
Closed

Drop Node 4 & 6 support from CLI #4200

bahmutov opened this issue May 15, 2019 · 6 comments
Assignees
Labels
cli type: breaking change Requires a new major release version type: chore Work is required w/ no deliverable to end user type: dependencies

Comments

@bahmutov
Copy link
Contributor

When one does npm install cypress one downloads NPM package built in "cli" folder. All production dependencies in "cli/package.json" currently support Node 4+ thus you can install Cypress even if you are rocking Node 4

But I am trying to verify downloaded binary zip file by using hasha in #4193 Hasha has dropped Node 4, 6 support so if we include it in the CLI production dependencies, our cypress npm package will no longer support Node 4 or 6 either.

In fact, it is hard for me to say if all our current production dependencies really run on Node 4 since many packages do not declare engines

Proposal

(even Node 6 has reached end-of-life as of April 2019)

@jennifer-shehane
Copy link
Member

jennifer-shehane commented May 16, 2019

I would like this also. I had to revert some updates that dropped support for Node 4, a lot of packages are dropping and it is preventing us from keeping up to date with their fixes.

I specifically had to revert PR updates for

I'd be happy to work on this. Will open a PR.

I think another issue with this is that this will require a breaking change release?

@jennifer-shehane jennifer-shehane self-assigned this May 16, 2019
@cypress-bot cypress-bot bot added the stage: ready for work The issue is reproducible and in scope label May 16, 2019
@jennifer-shehane jennifer-shehane added cli type: chore Work is required w/ no deliverable to end user type: dependencies stage: ready for work The issue is reproducible and in scope type: breaking change Requires a new major release version and removed stage: ready for work The issue is reproducible and in scope labels May 16, 2019
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: ready for work The issue is reproducible and in scope stage: work in progress labels May 16, 2019
@brian-mann
Copy link
Member

Sure - I am in favor of this, we can drop node 4 support in the next release after 3.3.0

@jennifer-shehane
Copy link
Member

jennifer-shehane commented May 17, 2019

Ok, so we are planning to release 3.3.0 without dropping Node 4 then we will craft a new 4.0 branch that will drop Node 4 and any PRs that are isolated fixes that we can pull in from the 4.0 epic. #2840 #2880

@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels May 17, 2019
@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 17, 2019

The code for this is done in cypress-io/cypress#4208, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@chrisbreiding chrisbreiding mentioned this issue May 21, 2019
18 tasks
@chrisbreiding chrisbreiding changed the title Drop Node 4 support from CLI Drop Node 4 & 6 support from CLI May 22, 2019
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 26, 2019

The code for this is done in cypress-io/cypress#5632, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 6, 2020

Released in 4.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v4.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Feb 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cli type: breaking change Requires a new major release version type: chore Work is required w/ no deliverable to end user type: dependencies
Projects
None yet
Development

No branches or pull requests

3 participants