Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropped frames in video recording from firefox #6369

Closed
kuceb opened this issue Feb 7, 2020 · 2 comments · Fixed by #6368
Closed

Dropped frames in video recording from firefox #6369

kuceb opened this issue Feb 7, 2020 · 2 comments · Fixed by #6368
Assignees
@kuceb
Labels
v4.0.0 🐛 Issue present since 4.0.0

Comments

@kuceb
Copy link
Contributor

kuceb commented Feb 7, 2020

Current behavior:

  • video recordings in firefox that visit a new domain or refresh window.top during test run will experience dropped frames.

Desired behavior:

  • entire test run is captured regardless of top navigation

Test code to reproduce

Versions

4.0.0
@kuceb kuceb added the v4.0.0 🐛 Issue present since 4.0.0 label Feb 7, 2020
@kuceb kuceb self-assigned this Feb 7, 2020
@kuceb kuceb mentioned this issue Feb 7, 2020
Merged
1 task
@cypress-bot cypress-bot bot added the stage: needs review The PR code is done & tested, needs review label Feb 7, 2020
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Feb 7, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 7, 2020

The code for this is done in cypress-io/cypress#6368, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 8, 2020

Released in 4.0.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v4.0.1, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Feb 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kuceb kuceb

Labels
v4.0.0 🐛 Issue present since 4.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ff): use fixed inputFPS instead of vfr to prevent dropped frames cypress-io/cypress
1 participant
@kuceb