If NPM config's noproxy is set, NO_PROXY rules will apply incorrectly

[flotwig]

Current behavior:

After merging #7900, changes in proxy-from-env cause the npm_config_noproxy environment variable to be considered above NO_PROXY. This is problematic because internally, we set NO_PROXY to contain the user's original NO_PROXY settings, as well as things which should never be proxied like localhost. The end result is bad behavior, like requests for localhost being sent through the proxy.

Desired behavior:

npm_config_noproxy acts as a fallback for NO_PROXY.

Workaround

Ensure that NPM config's noproxy setting is empty when launching Cypress, so that NO_PROXY is preferred. This can be done via environment variables.

For example (Linux/macOS):

npm_config_noproxy= npm run cypress:run

Or on Windows, using cross-env:

cross-env npm_config_noproxy= npm run cypress:run

┆Issue is synchronized with this Jira Features by Unito

[flotwig]

For now I think it's best to just revert the dep update, and wait to see if https://github.com/Rob--W/proxy-from-env/issues/13 is implemented, in which case we can use that version.

[jennifer-shehane]

this update shouldn't affect users

Famous last words

[cypress-bot]

The code for this is done in cypress-io/cypress#8295, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

[cypress-bot]

Released in 5.1.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v5.1.0, please open a new issue.