From 5e54ce3f643b044de24ce750dfabbf486a9e291b Mon Sep 17 00:00:00 2001
From: Mark Noonan <mark@cypress.io>
Date: Wed, 4 Jan 2023 12:56:34 -0500
Subject: [PATCH 1/3] feat: add tooltip and test for ellipsis

---
 packages/app/src/debug/DebugFailedTest.cy.tsx |  5 ++++-
 packages/app/src/debug/DebugFailedTest.vue    | 15 ++++++++++++++-
 2 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/packages/app/src/debug/DebugFailedTest.cy.tsx b/packages/app/src/debug/DebugFailedTest.cy.tsx
index 9d778318e27d..1c43e3dbfcb1 100644
--- a/packages/app/src/debug/DebugFailedTest.cy.tsx
+++ b/packages/app/src/debug/DebugFailedTest.cy.tsx
@@ -175,7 +175,7 @@ describe('<DebugFailedTest/>', () => {
     cy.percySnapshot()
   })
 
-  it('tests responsvie UI', { viewportWidth: 700 }, () => {
+  it('tests responsive UI', { viewportWidth: 700 }, () => {
     const testResult: TestResults = {
       id: '676df87874',
       titleParts: ['Test content', 'Test content 2', 'Test content 3', 'Test content 4', 'onMount() should be called once', 'hook() should be called twice and then'],
@@ -197,6 +197,9 @@ describe('<DebugFailedTest/>', () => {
 
     assertRowContents(testResult)
 
+    cy.contains('...').realHover()
+    cy.contains('[data-cy=tooltip-content]', 'Test content 2').should('be.visible')
+
     cy.percySnapshot()
   })
 })
diff --git a/packages/app/src/debug/DebugFailedTest.vue b/packages/app/src/debug/DebugFailedTest.vue
index b7659c16f996..a4d923333f47 100644
--- a/packages/app/src/debug/DebugFailedTest.vue
+++ b/packages/app/src/debug/DebugFailedTest.vue
@@ -30,7 +30,17 @@
           titlePart.type === 'LAST-1' ? 'shrink-0 whitespace-pre' :
           titlePart.type === 'LAST-0' ? 'pl-2.5 truncate' : 'px-2.5 truncate'"
       >
-        {{ titlePart.title }}
+        <template v-if="titlePart.title === '...'">
+          <Tooltip>
+            <span>...</span>
+            <template #popper>
+              <span data-cy="tooltip-content">{{ titlePart.originalTitle }}</span>
+            </template>
+          </Tooltip>
+        </template>
+        <template v-else>
+          {{ titlePart.title }}
+        </template>
       </span>
     </template>
     <div
@@ -69,6 +79,7 @@ import GroupedDebugFailedTestVue from './GroupedDebugFailedTest.vue'
 import { computed } from 'vue'
 import type { TestResults } from './DebugSpec.vue'
 import type { StatsMetadata_GroupsFragment } from '../generated/graphql'
+import Tooltip from '@packages/frontend-shared/src/components/Tooltip.vue'
 
 const props = defineProps<{
   failedTestsResult: TestResults[]
@@ -84,6 +95,7 @@ const failedTestData = computed(() => {
   type MappedTitlePart = {
     title: string
     type: Parts
+    originalTitle?: string
   }
   let isFirstMiddleAdded: boolean = false
   const mappedTitleParts: MappedTitlePart[] = titleParts.map<MappedTitlePart | MappedTitlePart[]>((ele, index, parts) => {
@@ -121,6 +133,7 @@ const failedTestData = computed(() => {
         {
           title: '...',
           type: 'ELLIPSIS',
+          originalTitle: ele,
         },
         {
           title: ele,

From 48790b5efa7b755c470ec078f3fa4396fa1b34ae Mon Sep 17 00:00:00 2001
From: Mark Noonan <mark@cypress.io>
Date: Thu, 5 Jan 2023 20:10:08 -0500
Subject: [PATCH 2/3] correct behavior, add comments, refactor for clarity

---
 packages/app/src/debug/DebugFailedTest.cy.tsx |  2 +-
 packages/app/src/debug/DebugFailedTest.vue    | 87 ++++++++++++-------
 2 files changed, 56 insertions(+), 33 deletions(-)

diff --git a/packages/app/src/debug/DebugFailedTest.cy.tsx b/packages/app/src/debug/DebugFailedTest.cy.tsx
index 1c43e3dbfcb1..bee1baaced66 100644
--- a/packages/app/src/debug/DebugFailedTest.cy.tsx
+++ b/packages/app/src/debug/DebugFailedTest.cy.tsx
@@ -198,7 +198,7 @@ describe('<DebugFailedTest/>', () => {
     assertRowContents(testResult)
 
     cy.contains('...').realHover()
-    cy.contains('[data-cy=tooltip-content]', 'Test content 2').should('be.visible')
+    cy.contains('[data-cy=tooltip-content]', 'Test content 2 > Test content 3 > Test content 4').should('be.visible')
 
     cy.percySnapshot()
   })
diff --git a/packages/app/src/debug/DebugFailedTest.vue b/packages/app/src/debug/DebugFailedTest.vue
index a4d923333f47..655af2c0b3b3 100644
--- a/packages/app/src/debug/DebugFailedTest.vue
+++ b/packages/app/src/debug/DebugFailedTest.vue
@@ -1,7 +1,7 @@
 <template>
   <div
     data-cy="test-row"
-    class="flex flex-row h-12 items-center non-italic text-base text-gray-700 font-normal"
+    class="flex flex-row font-normal h-12 text-base text-gray-700 items-center non-italic"
   >
     <SolidStatusIcon
       size="16"
@@ -10,36 +10,36 @@
       class="isolate"
     />
     <template
-      v-for="titlePart, index in failedTestData.mappedTitleParts"
+      v-for="{text, type}, index in failedTestData.mappedTitleParts"
       :key="`${titlePart}-${index}`"
       :data-cy="`titleParts-${index}`"
     >
       <IconChevronRightSmall
-        v-if="index !== 0 && titlePart.type !== 'LAST-1'"
+        v-if="index !== 0 && type !== 'LAST-PART-END'"
         :data-cy="`titleParts-${index}-chevron`"
         size="8"
         stroke-color="gray-200"
         fill-color="gray-200"
         class="shrink-0"
-        :class="titlePart.type === 'MIDDLE' ? 'hidden lg:block' : titlePart.type === 'ELLIPSIS' ? 'lg:hidden' : ''"
+        :class="type === 'MIDDLE' ? 'hidden lg:block' : type === 'ELLIPSIS' ? 'lg:hidden' : ''"
       />
       <span
         :data-cy="`titleParts-${index}-title`"
-        :class="titlePart.type === 'ELLIPSIS' ? 'px-2.5 shrink-0 lg:hidden' :
-          titlePart.type === 'MIDDLE' ? 'truncate px-2.5 hidden lg:block' :
-          titlePart.type === 'LAST-1' ? 'shrink-0 whitespace-pre' :
-          titlePart.type === 'LAST-0' ? 'pl-2.5 truncate' : 'px-2.5 truncate'"
+        :class="type === 'ELLIPSIS' ? 'px-2.5 shrink-0 lg:hidden' :
+          type === 'MIDDLE' ? 'truncate px-2.5 hidden lg:block' :
+          type === 'LAST-PART-END' ? 'shrink-0 whitespace-pre' :
+          type === 'LAST-PART-START' ? 'pl-2.5 truncate' : 'px-2.5 truncate'"
       >
-        <template v-if="titlePart.title === '...'">
+        <template v-if="type === 'ELLIPSIS'">
           <Tooltip>
-            <span>...</span>
+            <span>{{ text }}</span>
             <template #popper>
-              <span data-cy="tooltip-content">{{ titlePart.originalTitle }}</span>
+              <span data-cy="tooltip-content">{{ middlePartText }}</span>
             </template>
           </Tooltip>
         </template>
         <template v-else>
-          {{ titlePart.title }}
+          {{ text }}
         </template>
       </span>
     </template>
@@ -87,63 +87,79 @@ const props = defineProps<{
   expandable: boolean
 }>()
 
+type ItemType = 'SHOW_FULL' | 'MIDDLE' | 'ELLIPSIS' | 'LAST-PART-START' | 'LAST-PART-END'
+  type MappedTitlePart = {
+    text: string
+    type: ItemType
+  }
+
 const failedTestData = computed(() => {
   const runInstance = props.failedTestsResult[0].instance
   const titleParts = props.failedTestsResult[0].titleParts
 
-  type Parts = 'FIRST' | 'MIDDLE' | 'PENULTIMATE' | 'ELLIPSIS' | 'LAST-0' | 'LAST-1'
-  type MappedTitlePart = {
-    title: string
-    type: Parts
-    originalTitle?: string
-  }
   let isFirstMiddleAdded: boolean = false
-  const mappedTitleParts: MappedTitlePart[] = titleParts.map<MappedTitlePart | MappedTitlePart[]>((ele, index, parts) => {
+
+  const mappedTitleParts: MappedTitlePart[] = titleParts.map<MappedTitlePart | MappedTitlePart[]>((titlePart, index, parts) => {
     if (index === 0) {
+      // always use the whole first part of the title
       return {
-        title: ele,
-        type: 'FIRST',
+        text: titlePart,
+        type: 'SHOW_FULL',
       }
     }
 
     if (index === parts.length - 1) {
+      // split the last part into 2 pieces, so that we can truncate the first half if needed,
+      // and still show the end of the text.
       return [
         {
-          title: ele.slice(0, ele.length - 15),
-          type: 'LAST-0',
+          text: titlePart.slice(0, titlePart.length - 15),
+          type: 'LAST-PART-START',
         },
         {
-          title: ele.slice(ele.length - 15),
-          type: 'LAST-1',
+          text: titlePart.slice(titlePart.length - 15),
+          type: 'LAST-PART-END',
         },
       ]
     }
 
     if (index === parts.length - 2 && parts.length >= 3) {
+      // this is the second-last part of the title,
+      // and will be the *third-to-last* item in the array.
+
+      // We only label this SHOW_FULL if there are enough
+      // actual parts in the title that it is required to separate this
+      // from "middle" items that may be hidden in smaller screens
+
       return {
-        title: ele,
-        type: 'PENULTIMATE',
+        text: titlePart,
+        type: 'SHOW_FULL',
       }
     }
 
     if (!isFirstMiddleAdded && parts.length > 3) {
       isFirstMiddleAdded = true
 
+      // a fake part with type ELLIPSIS is shown conditionally
+      // at smaller screen sizes
+
+      // we insert it here and will flatten the result later
+      // to undo the nesting this creates
       return [
         {
-          title: '...',
+          text: '...',
           type: 'ELLIPSIS',
-          originalTitle: ele,
         },
         {
-          title: ele,
+          text: titlePart,
           type: 'MIDDLE',
         },
       ]
     }
 
-    return { title: ele, type: 'MIDDLE' }
-  }).flat()
+    return { text: titlePart, type: 'MIDDLE' }
+  })
+  .flat() // flatten the array since one of the internal items may itself be an array.
 
   return {
     debugArtifacts: [
@@ -155,6 +171,13 @@ const failedTestData = computed(() => {
   }
 })
 
+const middlePartText = computed(() => {
+  return failedTestData.value.mappedTitleParts
+  .filter((item) => item.type === 'MIDDLE')
+  .map((item) => item.text)
+  .join(' > ')
+})
+
 </script>
 <style scoped>
 [data-cy=test-group]:hover .test-row-artifacts, [data-cy=test-group]:focus-within .test-row-artifacts {

From 59a78e3c573e49fc2b4f787a92854a279ca78674 Mon Sep 17 00:00:00 2001
From: Mark Noonan <mark@cypress.io>
Date: Thu, 5 Jan 2023 20:25:57 -0500
Subject: [PATCH 3/3] accessibility

---
 packages/app/src/debug/DebugFailedTest.vue | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/packages/app/src/debug/DebugFailedTest.vue b/packages/app/src/debug/DebugFailedTest.vue
index 655af2c0b3b3..55c93feb7428 100644
--- a/packages/app/src/debug/DebugFailedTest.vue
+++ b/packages/app/src/debug/DebugFailedTest.vue
@@ -32,7 +32,9 @@
       >
         <template v-if="type === 'ELLIPSIS'">
           <Tooltip>
-            <span>{{ text }}</span>
+            <!-- button gives us free keyboard focus activation of the tooltip -->
+            <button>{{ text }}</button>
+            <span class="sr-only">{{ middlePartText }}</span>
             <template #popper>
               <span data-cy="tooltip-content">{{ middlePartText }}</span>
             </template>