Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parity between pycytominer 1.0 and cytominer #94

Closed
niranjchandrasekaran opened this issue Aug 14, 2020 · 1 comment
Closed

Parity between pycytominer 1.0 and cytominer #94

niranjchandrasekaran opened this issue Aug 14, 2020 · 1 comment
Labels
question Further information is requested

Comments

@niranjchandrasekaran
Copy link
Member

With the imminent release of pycytominer 1.0, @gwaygenomics has been cleaning up some the pycytominer repo and removing some evaluation functions (#92) that will be moved to the cytominer-eval repo (cytomining/cytominer-eval#3 (comment)).

Though splitting the repository into two (pycytominer for profile processing scripts and cytominer-eval for evaluation scripts) is logical and shouldn't majorly affect any profiling workflows, I was wondering if this decision to split is relevant in the context of how pycytominer 1.0 will be advertised upon release.

  • Would pycytominer 1.0 be the python version of the latest cytominer release, in which case, it maybe beneficial to keep the evaluation functions in pycytominer 1.0 so that it doesn't break the parity between pycytominer and cytominer.

  • Or can pycytominer 1.0 be considered to have sufficiently diverged from cytominer that it longer matters whether there is parity in functionality (as @gwaygenomics said on slack, it can be argued that an earlier hash of pycytominer should still have the evaluation functionalities)?

@gwaybio gwaybio added the question Further information is requested label Aug 17, 2020
@gwaybio
Copy link
Member

gwaybio commented Aug 20, 2020

from our internal discussions today, we will move forward without the need for parity between pycytominer and cytominer. Our rationale was that requiring this parity slows progress in one tool vs. the other.

We will continue using cytominer in internal assay dev projects, but we will not restrict ourselves in developing the python version.

Going to consider this issue resolved for now, but we can feel free to reopen if new info comes our way

@gwaybio gwaybio closed this as completed Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants