Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap "e" and "w" resize controls to align DOM with actual view #32

Closed
zakimaksyutov opened this issue Dec 7, 2017 · 1 comment
Closed

Swap "e" and "w" resize controls to align DOM with actual view #32

zakimaksyutov opened this issue Dec 7, 2017 · 1 comment

Comments

@zakimaksyutov
Copy link

zakimaksyutov commented Dec 7, 2017 •
edited
Loading

Right now "east resize" goes first (example from v3 but v4 has the same order):

image

Impact

When extending resize controls to be focusable, focus/screen reader still follows DOM order and as a result goes in reverse order:

brush-taborder2

Potential fix

Swap "e" and "w" in array of handles to align DOM order with actual view.
@mbostock
Copy link
Member

mbostock commented Aug 2, 2019

Thanks for the suggestion and sorry for the delay! This has been fixed.

@mbostock mbostock mentioned this issue Aug 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mbostock @zakimaksyutov