Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Max Button on Deposits and Withdrawals #362

Closed
magentaceiba opened this issue Oct 26, 2022 · 0 comments
Closed

Correct Max Button on Deposits and Withdrawals #362

magentaceiba opened this issue Oct 26, 2022 · 0 comments
Assignees

Comments

@magentaceiba
Copy link
Contributor

Description (what needs to be done) / Expected Behavior
The max button for deposit modal needs to show the accurate balance and work, and we need to add the button to withdrawals.

Acceptance Criteria
The max button shows on deposit and withdrawal modal on main Homebase and Lambda. It shows the correct balance from the user's wallet, in the correct decimal format. The max button also shows and works correctly on withdrawals.

Supporting information (Figma link, notes, etc)

The reported errors still happening include:
The token balances are being called from tzkt API, but are not paginating and using the default limit of 100. So if the token is not in the first 100 returned from the API, the balance is zero. This user has thousands of tokens in their wallet because they also have NFT's.

This is an edge case, but it's for a lead developer in the most important community user base on Homebase right now, and we need to fix it in a timely way. As Homebase userbase scales, it will not be uncommon for users to have over 100 tokens in their wallet due to the volume of NFT activity on Tezos.

Other potential error information:
Corey: "It's not only the max button, his balance is also missing on the deposit modal which is likely the cause. Maybe there's still a React state issue and it wasn't fully fixed? I can see that he does have a balance on-chain but it's not showing in his deposit modal, shows as 0."

When finished, please add Link to the PR or completed Figma / design asset, as a comment to the ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants