Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WithFgColor doesn't match colored::Colorize's behavior #100

Open
daboross opened this issue Apr 15, 2022 · 0 comments
Open

WithFgColor doesn't match colored::Colorize's behavior #100

daboross opened this issue Apr 15, 2022 · 0 comments

Comments

@daboross
Copy link
Owner

colored::Colorize will specifically not color things if NO_COLOR env variable is set, or other conditions per ShouldColorize.

We ignore this, and thus have inconsistency. As of #99, we also patch a test to ignore this inconsistency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@daboross