Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Add auto-merge support for sync-upstream workflow #161

Closed
piyoki opened this issue Jul 14, 2023 · 3 comments · Fixed by #162
Closed

[CI] Add auto-merge support for sync-upstream workflow #161

piyoki opened this issue Jul 14, 2023 · 3 comments · Fixed by #162
Assignees
@piyoki
Labels
topic/enhancement

Comments

@piyoki
Copy link
Contributor

piyoki commented Jul 14, 2023 •
edited
Loading

Why is this needed

Currently, PRs proposed by @daeBot for sync-upstream workflow are NOT able to be merged automatically.

The proposed solution is to integrate check runs to indicate if all stages/steps in pr-build workflow are passed. If it is such a case per PR, dae-bot[bot] will merge the PR automatically. In case of any build failure occurs in the PR build, dae-bot[bot] will halt the auto-merge and alert the stakeholders instead.

References:

Implementaion

https://github.com/daeuniverse/dae-bot/pull/71
@piyoki piyoki self-assigned this Jul 14, 2023
@dae-prow
Copy link
Contributor

dae-prow bot commented Jul 14, 2023

Thanks for opening this issue!

@piyoki piyoki mentioned this issue Jul 14, 2023
Merged
3 tasks
@piyoki piyoki reopened this Jul 14, 2023
@piyoki
Copy link
Contributor Author

piyoki commented Jul 14, 2023

Still need to implement check-run event listener for dae-bot

@piyoki
Copy link
Contributor Author

piyoki commented Jul 15, 2023

Still need to implement check-run event listener for dae-bot

Implemented in https://github.com/daeuniverse/dae-bot/pull/71

@piyoki piyoki closed this as completed Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@piyoki piyoki

Labels
topic/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci(pr-build): integrate check runs to report build status daeuniverse/daed
1 participant
@piyoki