Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement elliptric-curve traits #373

Closed
daxpedda opened this issue Oct 12, 2021 · 3 comments
Closed

Implement elliptric-curve traits #373

daxpedda opened this issue Oct 12, 2021 · 3 comments

Comments

@daxpedda
Copy link

I propose implementing some of the traits defined in elliptic-curve to improve compatibility with downstream users.

Specifically Group, GroupEncoding and Field is what I had in mind.

I'm working on a PR as we speak.

@kayabaNerve
Copy link
Contributor

kayabaNerve commented Apr 21, 2022

Is there any chance this will be done for EdwardsPoint as well (perhaps in another PR)? I don't believe group has the necessary functions to handle torsion, which would explain why it's not being done in that PR, yet it should at least be possible to provide group bindings with a main subgroup requirement. That may be a higher level decision than desired (see discussion on #380), yet my current workaround is my own library stubbing out parts of ff/group as needed (with a main subgroup check when decoding). I'd really love to be able to delete it in favor of this PR (or a relative), yet unfortunately do need to work with Ed25519.

Even if no one's willing to step up to the plate to handle this right now, I would be curious if such a PR would be accepted. I didn't believe elliptic-curve in general would be yet the positive response to this PR made me want to inquire.

@daxpedda
Copy link
Author

I believe this can be closed now that #562 is merged?

@rozbb
Copy link
Contributor

rozbb commented Aug 28, 2023

Yup!

@rozbb rozbb closed this as completed Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants