Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin starts the verify phase #270

Open
MrAlucardDante opened this issue Aug 20, 2024 · 3 comments
Open

Plugin starts the verify phase #270

MrAlucardDante opened this issue Aug 20, 2024 · 3 comments

Comments

@MrAlucardDante
Copy link

MrAlucardDante commented Aug 20, 2024

Looks like this #250 broke the execution policies in maven.
Starting with version 5.8.2, which includes this PR, the plugin executes the verify stage on its own even though I have executed the test phase. That result in broken builds in our current pipeline because the test phase and the verify phase use 2 different profiles.

Here is the plugin part from my pom :

<plugin>
        <groupId>net.masterthought</groupId>
        <artifactId>maven-cucumber-reporting</artifactId>
        <version>5.8.2</version>
        <executions>
          <execution>
            <id>cucumber-report</id>
            <phase>test</phase>
            <goals>
              <goal>generate</goal>
            </goals>
            <configuration>
              <projectName>service</projectName>
              <skip>${maven.test.skip}</skip>
              <outputDirectory>
                ${project.build.directory}/cucumber-reports/
              </outputDirectory>
              <inputDirectory>
                ${project.build.directory}/cucumber-reports/
              </inputDirectory>
              <jsonFiles>
                <param>**/TestCucumber.json</param>
              </jsonFiles>
              <checkBuildResult>true</checkBuildResult>
            </configuration>
          </execution>
        </executions>
      </plugin>

and the logs that shows the start of the verify phase by the plugin:

[INFO] >>> plugin:5.8.2:generate (cucumber-report) > verify @ service

If I run mvn test on 5.8.1, there is no issue

[INFO] --- plugin:5.8.1:generate (cucumber-report) @ service

@MrAlucardDante MrAlucardDante changed the title Plugin starts the verify phase even when not told to Plugin starts the verify phase Aug 20, 2024
@damianszczepanik
Copy link
Owner

This is not critical change so I can revert this if this helps you

@MrAlucardDante
Copy link
Author

This is not critical change so I can revert this if this helps you

If it's ok with you, this would be great, but we are fine staying on the previous version. There wasn't much change in this release anyway

@damianszczepanik
Copy link
Owner

Change is reverted, let me know if this fixes the problem before I prepare release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants