Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrectly uses usize instead of u64 for file offsets #67

Open
peter-bertok opened this issue Jul 5, 2018 · 2 comments
Open

Incorrectly uses usize instead of u64 for file offsets #67

peter-bertok opened this issue Jul 5, 2018 · 2 comments

Comments

@peter-bertok
Copy link

As per the discussion here: https://users.rust-lang.org/t/rust-beginner-notes-questions/14928/81?u=peter_bertok

The file offset should be consistently u64 everywhere instead of usize, even on 32-bit platforms. In practice, I believe Windows doesn't actually support mapping more than 2 GB on 32-bit, so isize::MAX might be a better window-size limit.

@dekellum
Copy link
Contributor

dekellum commented Jul 9, 2018

Might this be fixed by #65?

@Dr-Emann
Copy link
Contributor

Dr-Emann commented Aug 7, 2019

I believe this was indeed fixed by #65, merged in #71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants