-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚀 Add option to override terminal's background color #153
Comments
Hi @jc00ke, thanks for opening an issue! It may be that I've done something that doesn't make sense or is surprising people. Currently, delta only alters the background color in added/removed lines. Otherwise, the background color is whatever your terminal emulator is producing. Is it that that's violating your expectations? |
I believe that bat takes the same approach: sharkdp/bat#339 (comment) Does this make sense? There have also been questions about it in #87. (Wouldn't it be rather visually jarring for delta/bat to produce different background colors from what your terminal is set to?) |
Ah, that makes sense, and yes, that's violating my expectations 😉 As for a jarring experience, yes, totally. I had |
It would be great to have an option to change the background for not changed lines too. This way we could use light themes for diff while still using a dark theme for terminal. |
@jc00ke @gpressutto5 @natsumi @lightspeedbriefs The Here's an example showing how to use a light theme with a dark terminal background, as @gpressutto5 suggested:
To build delta from source:You'll need to install the rust tools.
Closing this because I think it's fixed, but as always please re-open if not. |
(
yadm
just forwards, and I tested it with baregit
too)Am I doing something silly? This is with
delta 0.1.1
on Linux withkitty 0.17.3
The text was updated successfully, but these errors were encountered: