-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Weird/unexpected output on VS Code with 0.17.0 #1735
Comments
The sequences stem from delta's background/foregreound color detection. The weird output is the terminal's response which you should normally not see. You can disable the automatic detection by explicitly specifying What version of VSCode are you running? Is delta also quite slow by any chance? |
I can confirm using the |
Unfortunately I can't reproduce this on my own mac or @janhohenheim's mac with VSCode 1.90.2 and delta 0.17.0. Follow-up questions:
I came up with a list of things that you could try to help figure out why this happens if you're up for it 😃
|
Note that we are both running Intel macs. I don't expect this to make a difference, but I've seen very weird issues come from different architectures in the past. |
I can't replicate the bug anymore. I don't know what changed about my system because I don't recall running updates in the last two days. I'm sorry if that means I/we pinpoint the error further if/when it reappears elsewhere. Here's the answers to your questions in case that's still relevant: I don't use a multiplexer and my delta config is as follows:
I'm not sure which parts of my VS Code settings are relevant so here's everything starting with
I tried compiling the version on your branch @bash and it worked fine (just like 0.16.5 and 0.17.0 do now). The output of your printf-Snippet is I also ran your example program and its output is |
@kfkonrad Thank you so much for working through my pinpoint steps 💛
No worries :) Let me know if the issue reappears. |
When running delta version 0.17.0 on a terminal in VS Code I get the following ouput:
Running delta in another terminal emulator such as iTerm or Terminal on my Mac yields the desired output. Due to this buggy ouput delta 0.17.0 is unusable on VS Code right now, at least on my machine.
I also did a
cargo build --release
to verify that the bug is still in the code base on main as of commit id f5b3717. The bug also comes up using zsh and fish as the shell btwThe bug does not occur with 0.16.5 so my quickfix for the meantime is to just use this older version.
The text was updated successfully, but these errors were encountered: